Fix tests #5
Merged
Fix tests #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New teams work - Fix issues around create flow
flurdy
approved these changes
Dec 17, 2024
- Send baseUrl and Debug to wdio as envs - Align local conf with base conf - Delete docker conf - Fix debug env now being passed correctly
feedmypixel
force-pushed
the
fix-tests
branch
from
7f09841 to
1a51634
Compare
flurdy
reviewed
Dec 17, 2024
| "test:docker": "npm run clean && wdio run wdio.docker.conf.js", | ||
| "test:local": "npm run clean && BASE_URL=\"http://localhost:3000\" wdio run wdio.local.conf.js", | ||
| "test:local:debug": "npm run clean && DEBUG=true BASE_URL=\"http://localhost:3000\" wdio run wdio.local.conf.js", | ||
| "test:docker": "npm run clean && BASE_URL=\"http://cdp.127.0.0.1.sslip.io:3333\" wdio run wdio.local.conf.js", |
There was a problem hiding this comment.
I was hoping we could remove the :docker one and just use the :local one listening to an env var if set otherwise default to localhost. That way we could also push this to the template and let tenants override it in an env var if they want to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.