Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFDP-152: Retry Synchronous Notify Failures #47

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

SFDP-152: Retry Synchronous Notify Failures #47

wants to merge 13 commits into from
+164 −23

Conversation

thousand-leaves
Copy link
Contributor

  • version bump
  • added code to handle duplicate requests
  • added code to handle duplicate requests
  • fixed code smell, sonar does not allow straigth if
  • removed unused let assigment
  • removed duplicate interaction with govNotify when check for duplicate
  • moved duplicate check to utils folder
  • refactored idempotent behavior
  • removed unused assigments in test-file
  • resolved sonar issue
  • refacotred into single function
  • resolved sonar
  • removing artifacts and improving tests

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thousand-leaves @JungaBunga