Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/ruby 3511 rails 7 2 #970

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Chore/ruby 3511 rails 7 2 #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cbdb2eb
Upgrade rails to v7.2
PaulDoyle-EA Dec 23, 2024
3452cbb
Lint fixes
PaulDoyle-EA Dec 23, 2024
1236cf7
Fix misconfigured multiline strings and other unit test issues
PaulDoyle-EA Dec 23, 2024
ef73575
Update coverage path command and sonarcloud GitHub action
PaulDoyle-EA Dec 23, 2024
6292589
remove stray comment
PaulDoyle-EA Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,13 @@ jobs:
- name: Run unit tests
run: |
bundle exec rspec
sed -i 's/\/home\/runner\/work\/pafs_core\/pafs_core\//\/github\/workspace\//g' coverage/coverage.json

- name: Update coverage output
run: |
sed -i "s@/home/runner/work/DEFRA/pafs_core@/github/workspace@g" coverage/coverage.json

- name: Analyze with SonarCloud
uses: sonarsource/sonarcloud-github-action@master
uses: sonarsource/sonarqube-scan-action@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # This is provided automatically by GitHub
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} # This needs to be set in your repo; settings -> secrets
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,5 @@ group :test do
gem "database_cleaner"
gem "faker"
gem "memory_profiler"
gem "rspec-retry"
end
Loading
Loading