Fix/ruby 3441 companies house gem (#1597)

https://eaflood.atlassian.net/browse/RUBY-3441
DEFRA · Jan 9, 2025 · 1c54e68 · 1c54e68
1 parent e0f5ca9
commit 1c54e68
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/app/models/concerns/waste_carriers_engine/can_use_renewing_registration_workflow.rb b/app/models/concerns/waste_carriers_engine/can_use_renewing_registration_workflow.rb
@@ -259,7 +259,7 @@ def company_status_invalid?
 
       begin
         company_status = DefraRuby::CompaniesHouse::API.run(company_number: company_no)[:company_status]
-        !%w[active voluntary-arrangement].include?(company_status)
+        !%i[active voluntary-arrangement].include?(company_status)
       rescue StandardError => e
         Rails.logger.error "Error checking company status: #{e}"
         Airbrake.notify(e)

diff --git a/...els/waste_carriers_engine/renewing_registration_workflow/renewal_information_form_spec.rb b/...els/waste_carriers_engine/renewing_registration_workflow/renewal_information_form_spec.rb
@@ -18,13 +18,8 @@ module WasteCarriersEngine
     let(:business_type) { nil }
     let(:location) { "england" }
     let(:companies_house_api) { instance_double(DefraRuby::CompaniesHouse::API) }
-    let(:companies_house_api_reponse) do
-      {
-        company_status:
-      }
-    end
-
-    let(:company_status) { "active" }
+    let(:companies_house_api_reponse) { { company_status: } }
+    let(:company_status) { :active }
     let(:company_number) { "12345678" }
 
     before do
@@ -76,8 +71,7 @@ module WasteCarriersEngine
 
           shared_examples "check_registered_company_name_form or invalid_company_status_form" do
 
-            %w[active
-               voluntary-arrangement].each do |status|
+            %i[active voluntary-arrangement].each do |status|
               context "with a company status of #{status}" do
                 let(:company_status) { status }