Add param_1_label & param_2_label to lvpct view
#1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEFRA/water-abstraction-service#2663 As part of the migration of legacy pages into the new system, we identified missing information in the licence_version_purpose_condition_types table. Specifically, the param1 and param2 values in the licence_version_purpose_conditions table are dynamically associated with row titles derived from the code and subcode in the licence_version_purpose_condition_types table. To correctly reference these row titles for each parameter, we added the static values to the licence_version_purpose_condition_types table. We now need to add the `param_1_label` and `param_2_label` to the licence_version_purpose_condition_types view. This PR introduces two new columns,`param_1_label` and `param_2_label` to the licence_version_purpose_condition_types view.
rvsiyad
added
the
housekeeping
…ce version purpose condition types
… licence version purpose condition types view
…ion types for tests
…icence-version-purpose-condition-types-view
…icence-version-purpose-condition-types-view
rvsiyad
deleted the
add-param1label-and-param2label-columns-to-licence-version-purpose-condition-types-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFRA/water-abstraction-service#2663
As part of the migration of legacy pages into the new system, we identified missing information in the licence_version_purpose_condition_types table. Specifically, the param1 and param2 values in the licence_version_purpose_conditions table are dynamically associated with row titles derived from the code and subcode in the licence_version_purpose_condition_types table. To correctly reference these row titles for each parameter, we added the static values to the licence_version_purpose_condition_types table. We now need to add the
param_1_labelandparam_2_labelto the licence_version_purpose_condition_types view.This PR introduces two new columns,
param_1_labelandparam_2_labelto the licence_version_purpose_condition_types view.