Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What do you want to do with this return? #1570

Merged
merged 84 commits into from
Jan 15, 2025
Merged

What do you want to do with this return? #1570

merged 84 commits into from
Jan 15, 2025

Conversation

Jozzey
Copy link
Contributor

@Jozzey Jozzey commented Dec 16, 2024

https://eaflood.atlassian.net/browse/WATER-4836

Build a page to enable the user to choose what they want to do with the return.

https://eaflood.atlassian.net/browse/WATER-4836

Build a page to enable the user to choose how they would like to edit a return.
@Jozzey Jozzey added the enhancement New feature or request label Dec 16, 2024
@Jozzey Jozzey self-assigned this Dec 16, 2024
@Jozzey Jozzey force-pushed the how-to-edit-return branch from 0803517 to ee51385 Compare January 15, 2025 08:49
As the back link is static and always goes to the licence page, but could be called from the TPT review screens. I've renamed it to make it clearer to users where the back link will take them.
@Jozzey Jozzey requested a review from Beckyrose200 January 15, 2025 11:08
Cruikshanks
Cruikshanks previously approved these changes Jan 15, 2025
Copy link
Contributor

@Beckyrose200 Beckyrose200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small comments :)

app/presenters/return-logs/setup/start.presenter.js Outdated Show resolved Hide resolved
app/views/return-logs/setup/start.njk Show resolved Hide resolved
app/views/return-logs/setup/start.njk Outdated Show resolved Hide resolved
test/controllers/return-logs-setup.controller.test.js Outdated Show resolved Hide resolved
Jozzey and others added 2 commits January 15, 2025 13:01
Co-authored-by: Becky Ransome <[email protected]>
@Jozzey Jozzey requested a review from Beckyrose200 January 15, 2025 13:02
Copy link
Contributor

@Beckyrose200 Beckyrose200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jozzey
Copy link
Contributor Author

Jozzey commented Jan 15, 2025

@Jozzey Jozzey merged commit 695cd47 into main Jan 15, 2025
7 checks passed
@Jozzey Jozzey deleted the how-to-edit-return branch January 15, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants