Fix miscalculated preview 2PT charge in review pt2 #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4849 In [Fix miscalculated preview 2PT charge in review](#1583) we attempted to resolve an issue where the two-part tariff preview charge feature was incorrectly telling the [Charging Module API](https://github.com/DEFRA/sroc-charging-module-api) to include the £141 water company charge in its calculation. We deduced the issue as being logic based on whether a field was populated, rather than also incorporating whether that value was 'true' or 'false'. What we didn't clock until testing was that when the value is populated, it is as a boolean value. However, out fetch service is casting it to text, which means our fix is still equating `isSupplyPublicWater = false` as 'true', because the value it is testing is `'false'` and not `false`. This updates the fetch service to cast the value properly, which then means the logic we amended in part 1 will now behave as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4849
In Fix miscalculated preview 2PT charge in review we attempted to resolve an issue where the two-part tariff preview charge feature was incorrectly telling the Charging Module API to include the £141 water company charge in its calculation.
We deduced the issue as logic based on whether a field was populated rather than incorporating whether that value was 'true' or 'false'.
What we didn't clock until testing was that when the value is populated, it is a boolean value. However, our fetch service is casting it to text, which means our fix still equates
isSupplyPublicWater = falseas 'true' because the value it is testing is'false'and notfalse.This updates the fetch service to cast the value properly, which means the logic we amended in part 1 will now behave as expected.