Skip to content

Merge pull request #389 from DFE-Digital/remove-transfers #204

Merge pull request #389 from DFE-Digital/remove-transfers

Merge pull request #389 from DFE-Digital/remove-transfers #204

Triggered via push October 5, 2023 15:02
Status Failure
Total duration 3m 15s
Artifacts
build-and-test
3m 3s
build-and-test
Fit to window
Zoom out
Zoom in

Annotations

1 error and 10 warnings
build-and-test
Process completed with exit code 1.
build-and-test: TramsDataApi/DatabaseModels/TrustMasterData.cs#L14
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
build-and-test: TramsDataApi/DatabaseModels/LegacyTramsDbContext.cs#L3331
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
build-and-test: TramsDataApi/Migrations/TramsDb/20221010150758_concernsDecisionStates.cs#L37
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
build-and-test: TramsDataApi/appsettings.json#L22
"password" detected here, make sure this is not a hard-coded credential. (https://rules.sonarsource.com/csharp/RSPEC-2068)
build-and-test: TramsDataApi/Middleware/ExceptionHandlerMiddleware.cs#L9
Move 'ExceptionHandlerMiddleware' into a named namespace. (https://rules.sonarsource.com/csharp/RSPEC-3903)
build-and-test: TramsDataApi/Factories/BaselineTrackerResponseFactory.cs#L6
Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)
build-and-test: TramsDataApi/Factories/EducationPerformanceFactories/GroupedEducationPerformanceFactory.cs#L5
Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)
build-and-test: TramsDataApi/Factories/EstablishmentListItemResponseFactory.cs#L6
Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)
build-and-test: TramsDataApi/Factories/EstablishmentResponseFactory.cs#L7
Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)
build-and-test: TramsDataApi/Factories/FurtherEducationEstablishmentResponseFactory.cs#L6
Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)