Skip to content

Commit

Permalink
Feature/173197 persons api client nu get package (#577)
Browse files Browse the repository at this point in the history
* Added a new step to the build workfow to build and publish a nuget package

* Changed the target condition so it wont run in CI

* Added a change for testing the new workflow

* Added environment varibale CI to the CI yaml file

* Added build-args in the docker-build

* Fixed the casing in teh target condition

* Modified target condition

* Modified target condition

* Added CI argument to the docker file, passed in from the docker build

* Passed in CI argument to the project build process

* Added CI argument to the docker build

* Added CI argument to the build-and-push-image.yml file

* Added changes to test Client Nuget Package deployment

* added CI argumetn tot he build command in continious integration file

* Added CI argument to the dotnet build in the dockerfile

* Updated to test nuget deployment

---------

Co-authored-by: Farshad DASHTI <[email protected]>
  • Loading branch information
FrostyApeOne and Farshad DASHTI authored Aug 14, 2024
1 parent 53732a8 commit 240b6a6
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Dfe.PersonsApi.Client/Generated/Client.g.cs
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ public virtual async System.Threading.Tasks.Task<MemberOfParliament> GetMemberOf
if (status_ == 404)
{
string responseText_ = ( response_.Content == null ) ? string.Empty : await response_.Content.ReadAsStringAsync().ConfigureAwait(false);
throw new PersonsApiException("Constituency not found", status_, responseText_, headers_, null);
throw new PersonsApiException("Constituency not found ", status_, responseText_, headers_, null);
}
else
if (status_ == 400)
Expand Down
2 changes: 1 addition & 1 deletion Dfe.PersonsApi.Client/Generated/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
}
},
"404": {
"description": "Constituency not found"
"description": "Constituency not found "
},
"400": {
"description": "Constituency cannot be null or empty"
Expand Down
2 changes: 1 addition & 1 deletion PersonsApi/Controllers/ConstituenciesController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public ConstituenciesController(IPersonsQueries personQueries)
[HttpGet("{constituencyName}/mp")]
[SwaggerOperation(Summary = "Retrieve Member of Parliament by constituency name", Description = "Receives a constituency name and returns a Person object representing the Member of Parliament.")]
[SwaggerResponse(200, "A Person object representing the Member of Parliament.", typeof(MemberOfParliament))]
[SwaggerResponse(404, "Constituency not found")]
[SwaggerResponse(404, "Constituency not found ")]
[SwaggerResponse(400, "Constituency cannot be null or empty")]
public async Task<IActionResult> GetMemberOfParliamentByConstituencyAsync([FromRoute] string constituencyName, CancellationToken cancellationToken)
{
Expand Down

0 comments on commit 240b6a6

Please sign in to comment.