Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add serilog api user enricher #388

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

paullocknimble
Copy link
Collaborator

  • tidy up of program.cs so serilog could be added
  • added custom enricher to apiuser to log properties

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

var enricher = services.GetRequiredService<ApiUserEnricher>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the GetRequiredService call it'll throw an exception if the service isn't registered. Is that what we want or do we want some handling of it? I'd guess it probably does constitute a exceptional state, so am happy as is

@dneed-nimble dneed-nimble self-requested a review October 5, 2023 12:18
@dneed-nimble dneed-nimble marked this pull request as ready for review October 5, 2023 12:18
@paullocknimble paullocknimble merged commit 56ad544 into main Oct 5, 2023
3 checks passed
@paullocknimble paullocknimble deleted the feature/add-serilog-api-user-enricher branch October 5, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants