Skip to content

Commit

Permalink
mend
Browse files Browse the repository at this point in the history
  • Loading branch information
richardpattinson committed Dec 2, 2024
1 parent 597af08 commit 1a08f90
Show file tree
Hide file tree
Showing 11 changed files with 23 additions and 22 deletions.
12 changes: 12 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,18 @@ RUN apk add --no-cache libpq
COPY --from=builder /app /app
COPY --from=builder /usr/local/bundle/ /usr/local/bundle/

# Set up puppeteer (for PDF generation)
# https://pptr.dev/troubleshooting#running-on-alpine
RUN apk add --no-cache \
chromium \
nss \
freetype \
harfbuzz \
ca-certificates \
ttf-freefont \
nodejs
ENV PUPPETEER_EXECUTABLE_PATH=/usr/bin/chromium-browser

# SSH access specific to Azure
# Install OpenSSH and set the password for root to "Docker!".
RUN apk add --no-cache openssh && echo "root:Docker!" | chpasswd
Expand Down
2 changes: 1 addition & 1 deletion app/components/induction_summary_component.rb
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def rows
}
]

if details.respond_to?(:certificate_url) && details.certificate_url.present?
if details.status == "Pass"
@rows << {
key: {
text: "Certificate"
Expand Down
2 changes: 1 addition & 1 deletion app/controllers/qualifications/certificates_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def show
formats: [:html],
locals: { teacher: @teacher, qualification: @qualification },
layout: "layouts/certificate")
grover = Grover.new(html, format: 'A4', display_url: request.base_url)
grover = Grover.new(html, format: 'A4', display_url: ENV["HOSTING_DOMAIN"])
pdf = grover.to_pdf
send_data pdf, filename: "#{@teacher.name}_#{@qualification.type.downcase}_certificate.pdf",
type: 'application/pdf', disposition: 'attachment'
Expand Down
2 changes: 1 addition & 1 deletion app/views/qualifications/certificates/_eyts.html.erb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<img src="/eyts-certificate.jpg" class="header-image" alt="Department for Education" />

<div class="content">
<h2 class="heading">Early years<br/>Teacher Status</h2>
<h2 class="heading">Early Years<br/>Teacher Status</h2>
<p class="text">This is to certify that: <strong><%= teacher.name %></strong></p>
<p class="text">Teacher Reference Number: <strong><%= teacher.trn %></strong></p>
<p>&#160;</p>
Expand Down
4 changes: 2 additions & 2 deletions app/views/qualifications/certificates/_induction.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
institution. The holder of this certificate is a qualified teacher and has obtained the required<br/>
qualifications and completed the necessary training for the profession of school teacher in England.</p>
<p>&#160;</p>
<p class="text">Date Induction Completed:&#160;<strong><%= qualification.awarded_at.to_fs(:long_uk) %></strong></p>
<p class="text">Date Induction Completed:&#160;<strong><%= qualification.details.periods.first.end_date.to_date.to_fs(:long_uk) %></strong></p>
<p>&#160;</p>
<p class="text">Congratulations and best wishes for your future career.</p>
<p>&#160;</p>
<p class="text">Any potential employer can independently confirm your teacher status online at:<br/>https://teacherservices.education.gov.uk</p>
<p class="text">Any potential employer can independently confirm your teacher status online at:<br/>https://www.gov.uk/guidance/check-a-teachers-record</p>
</div>
2 changes: 1 addition & 1 deletion app/views/qualifications/certificates/_npq.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<div class="content-npq">
<p class="text-npq">This is to certify that:</p>
<h2 class="heading-npq"> <%= teacher.name %></h2>
<h2 class="heading-npq name-heading-npq"> <%= teacher.name %></h2>
<p class="text-npq">has been awarded the</p>
<h2 class="heading-npq">
<strong>
Expand Down
2 changes: 1 addition & 1 deletion app/views/qualifications/certificates/_qts.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@
<p>&#160;</p>
<p class="text">Congratulations and best wishes for your future career</p>
<p>&#160;</p>
<p class="text">Any potential employer can independently confirm your teacher status online at:<br/>https://teacherservices.education.gov.uk</p>
<p class="text">Any potential employer can independently confirm your teacher status online at:<br/>https://www.gov.uk/guidance/check-a-teachers-record</p>
</div>
2 changes: 1 addition & 1 deletion config/database.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
default: &default
adapter: postgresql
encoding: unicode
url: <%= ENV.fetch('DATABASE_URL', 'postgres://postgres@localhost:5432') %>
url: <%= ENV.fetch('DATABASE_URL', 'postgres://postgres@localhost:5434') %>

development:
<<: *default
Expand Down
3 changes: 2 additions & 1 deletion config/initializers/grover.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
bottom: "0",
left: "0",
right: "0"
}
},
launch_args: ["--no-sandbox", "--disable-setuid-sandbox"],
}
config.use_jpeg_middleware = false
config.use_png_middleware = false
Expand Down
12 changes: 0 additions & 12 deletions spec/components/induction_summary_component_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -57,17 +57,5 @@
expect(rendered.css(".govuk-summary-list__key").map(&:text)).not_to include("Completed")
expect(rendered.css(".govuk-summary-list__key").map(&:text)).not_to include("End date")
end

context "when the certificate URL is missing" do
let(:induction) do
fake_quals_data.fetch("induction").tap do |data|
data.delete(:certificate_url)
end
end

it "does not render the certificate row when certificate URL is missing" do
expect(rendered.css(".govuk-summary-list__key").map(&:text)).not_to include("Certificate")
end
end
end
end
2 changes: 1 addition & 1 deletion spec/rails_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
WebMock.disable_net_connect!(allow_localhost: true)

Capybara.register_driver(:cuprite) do |app|
Capybara::Cuprite::Driver.new(app, timeout: 30, process_timeout: 40, window_size: [1200, 800])
Capybara::Cuprite::Driver.new(app, timeout: 200, process_timeout: 120, window_size: [1200, 800])
end
Capybara.default_driver = :cuprite
Capybara.javascript_driver = :cuprite
Expand Down

0 comments on commit 1a08f90

Please sign in to comment.