Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page titles to match h1s #345

Merged
merged 1 commit into from
Sep 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/views/check_records/search/new.html.erb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<% content_for :page_title, "Find teacher record" %>

<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">
<h1 class="govuk-heading-l">Find teacher record</h1>
Expand Down
1 change: 1 addition & 0 deletions app/views/check_records/search/show.html.erb
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<% content_for :page_title, "Search results (#{@total})" %>
<% content_for :breadcrumbs, govuk_breadcrumbs(breadcrumbs: { "Home" => check_records_search_path, "Search results" => nil }) %>

<div class="govuk-grid-row">
Expand Down
2 changes: 2 additions & 0 deletions app/views/check_records/sign_in/new.html.erb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<% content_for :page_title, "Sign in" %>

<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">

Expand Down
1 change: 1 addition & 0 deletions app/views/check_records/teachers/not_found.html.erb
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<% content_for :page_title, "Teacher not found" %>
<% content_for :back_link_url, check_records_search_path %>

<div class="govuk-grid-row">
Expand Down
1 change: 1 addition & 0 deletions app/views/check_records/teachers/show.html.erb
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<% content_for :page_title, @teacher.name %>
<% content_for :breadcrumbs, govuk_breadcrumbs(breadcrumbs: { "Home" => check_records_search_path, "Search results" => url_for(:back), @teacher.name => nil}) %>

<div class="govuk-grid-row">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ def and_search_returns_a_restricted_record
end

def then_i_see_the_restriction_on_the_result
expect(page).to have_title("Search results (1) - Check the record of a teacher in England")
expect(page).to have_content("RESTRICTIONS")
end

Expand All @@ -39,5 +40,6 @@ def then_i_see_the_details_of_the_restriction
expect(page).to have_content("RESTRICTIONS")
expect(page).to have_content("Failed induction")
expect(page).to have_content("25 October 2020")
expect(page).to have_title("Terry Walsh - Check the record of a teacher in England")
end
end
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,6 @@ def and_view_a_teacher_with_an_invalid_trn

def then_i_see_a_not_found_page
expect(page).to have_content "Teacher not found"
expect(page).to have_title "Teacher not found - Check the record of a teacher in England"
end
end