Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit summary list rows with no values #383

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

steventux
Copy link
Contributor

@steventux steventux commented Oct 9, 2023

Context

When displaying a summary list with values that could be blank we should omit the blank rows.
Summary lists with no data should not be displayed.

Changes proposed in this pull request

  • Hide blank rows in Qualification summary lists
  • Do not render summary list components with no data

Guidance to review

Link to Trello card

https://trello.com/c/Gpg69pIJ/208-hide-panel-rows-that-have-empty-data

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@steventux steventux force-pushed the 208-hide-panel-rows-that-have-empty-data branch 2 times, most recently from deaab96 to 652fef9 Compare October 9, 2023 13:38
@steventux steventux marked this pull request as ready for review October 9, 2023 14:37
@steventux steventux force-pushed the 208-hide-panel-rows-that-have-empty-data branch from 4632b94 to c84afcb Compare October 9, 2023 14:38
@steventux steventux requested a review from malcolmbaig October 9, 2023 16:21
@steventux
Copy link
Contributor Author

@steventux steventux merged commit e48799f into main Oct 11, 2023
12 checks passed
@steventux steventux deleted the 208-hide-panel-rows-that-have-empty-data branch October 11, 2023 09:01
@steventux steventux temporarily deployed to review October 11, 2023 09:01 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants