Add description to sanctions #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixclack
force-pushed
the
descriptions
branch
from
10d8487 to
0ab63bc
Compare
malcolmbaig
reviewed
Nov 20, 2023
We have expanded the sanctions list to also display a description alongside the title. This data isn't provided by the API so we opted to define it the same way we do with the titles. The descriptions contain links and we want them to be clickable so using markdown made sense here. The library is already being used elsewhere in the app, so there is no extra dependency required. Also, we control the markdown text itself, so there is no security risk by rendering this using the `html_safe` method. The use of `CHOMP` on the heredoc is to ensure we avoid the trailing newline character that a heredoc automatically adds.
felixclack
force-pushed
the
descriptions
branch
from
f1e05f0 to
9c75675
Compare
malcolmbaig
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have expanded the sanctions list to also display a description
alongside the title.
This data isn't provided by the API so we opted to define it the same
way we do with the titles.
The descriptions contain links and we want them to be clickable so
using markdown made sense here.
The library is already being used elsewhere in the app, so there is no
extra dependency required. Also, we control the markdown text itself, so
there is no security risk by rendering this using the
html_safemethod.
The use of
CHOMPon the heredoc is to ensure we avoid the trailingnewline character that a heredoc automatically adds.
Link to Trello card
https://trello.com/c/XqT7t8dV/150-add-a-description-field-for-sanctions
Checklist