Add result_count to SearchLog #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcolmbaig
changed the title
Whenever a search happens in Check, we want to record the number of results returned. This will help with analysis and potentially provide some UX insight.
malcolmbaig
force-pushed
the
218-surface-number-of-search-results-for-analytics
branch
from
176cbf7 to
801530f
Compare
steventux
approved these changes
Nov 20, 2023
malcolmbaig
deleted the
218-surface-number-of-search-results-for-analytics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Whenever a search happens in Check, we want to record the number of results returned. This will help with analysis and potentially provide some UX insight.
Changes proposed in this pull request
result_countinteger field to SearchLogGuidance to review
[DNM] tag is because we need to confirm how to update dataform before merging this PR.
Link to Trello card
https://trello.com/c/iKCySmlO/218-surface-the-number-of-search-results-for-analytics
Checklist