Handle missing programmeType for ITT qualifications
#434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steventux
changed the title
programmeType for ITT qualifications
malcolmbaig
approved these changes
Nov 20, 2023
steventux
deleted the
242-fix-aytq-template-error-from-qualifications-api-response
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have a sentry error in production where the qualifications API returns no
programmeTypeproperty for an ITT qualification.https://dfe-teacher-services.sentry.io/issues/4650996545/?alert_rule_id=14607780&alert_type=issue¬ification_uuid=27ce023f-8a29-4289-9d1a-844ca7425e8b&project=4505227155996672
We recently added ordering of qualifications by type, and this included differentiating ITT qualifications by programme type.
This is likely the cause of the error.
Changes proposed in this pull request
Allow for null programmeType and default to adding the ITT qualification as a QTS type.
Guidance to review
Link to Trello card
Checklist