Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1901 aytq deploy review apps using workflow #803

Merged
merged 37 commits into from
Sep 5, 2024

Conversation

shaheislamdfe
Copy link
Contributor

Context

To allow for deploy based on a specific label for review apps into new AKS environment.

Changes proposed in this pull request

Addiitonal deploy step for AKS aswell as specific Github action deploy workflow tailored to AKS deploy, referencing the aks make targets.

Guidance to review

Add the label to the PR deploy-aks and watch review app generate with working URL based on PR number. Validate smoke tests pass also. Close PR and validate destroy action runs

Link to Trello card

https://trello.com/c/nS67c3cG/1901-aytq-deploy-review-apps-using-workflow

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@shaheislamdfe shaheislamdfe marked this pull request as ready for review August 28, 2024 13:59
@shaheislamdfe shaheislamdfe requested a review from a team as a code owner August 28, 2024 13:59
@shaheislamdfe shaheislamdfe requested review from saliceti and removed request for a team August 28, 2024 13:59
Copy link

github-actions bot commented Aug 29, 2024

The review apps Access Your Teaching Qualifications & Check A Teacher's Record have been deleted.
The following domains are not available anymore:

.github/workflows/build-and-deploy.yml Show resolved Hide resolved
.github/workflows/delete-review-app.yml Outdated Show resolved Hide resolved
.github/workflows/delete-review-app.yml Outdated Show resolved Hide resolved
.github/workflows/delete-review-app.yml Show resolved Hide resolved
1901: Adding template for workflow labelling

1901: Adding template for workflow labelling

1901: Adding template for workflow labelling

1901: Adding template for workflow labelling

1901: Adding template for workflow labelling

1901: Adding template for workflow labelling
… match existing makefile

1901: correcting deploy action reference

1901: correcting deploy action reference

1901: correcting deploy action reference
1901: Correcting image tag reference
1901: Setting URLs statically
1901: Correcting job stage
Copy link

github-actions bot commented Sep 5, 2024

Review app Access Your Teaching Qualifications deployed to https://access-your-teaching-qualifications-pr-803.test.teacherservices.cloud was deleted
Review app Check A Teacher's Record deployed to https://check-a-teachers-record-pr-803.test.teacherservices.cloud was deleted

@shaheislamdfe shaheislamdfe merged commit 2dd387c into main Sep 5, 2024
13 checks passed
@shaheislamdfe shaheislamdfe deleted the 1901-aytq-deploy-review-apps-using-workflow branch September 5, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants