Move pii fields to analytics_hidden_pii #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpattinson
force-pushed
the
hide_pii_data
branch
from
4853cd5 to
9bd8775
Compare
felixclack
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Get an Identity service: does not use dfe-analytics but a rather older .NET package. It only contains web request data so there is no need for any hidden PII work
Check a Teacher's Record, Access your Teaching Qualifications and Check the Children's Barred List requires
dfe-analytics upgrade to version 1.14.2
copy analytics_pii.yml to analytics_hidden_pii.yml
clear analytics_pii.yml with an empty hash, after share:
raise PR / merge
Changes proposed in this pull request
Move pii to a new analytics_hidden_pii file.
Guidance to review
Link to Trello card
Checklist