Add pagination for the bulk search results #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixclack
force-pushed
the
pagination-bulk-search
branch
3 times, most recently
from
38ca746 to
62eab2f
Compare
The bulk search can return hundreds of results and currently the UI shows them all in a long table. We want to make this a better UX by introducing pagination. In order to make this new UX work, we need to store the API response in a table as the API itself isn't paginated. To avoid making the same API request over and over again to paginate, we store the response and set an expiration value. This is effectively a simple caching system.
felixclack
force-pushed
the
pagination-bulk-search
branch
from
62eab2f to
e93a2f6
Compare
richardpattinson
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk search can return hundreds of results and currently the UI
shows them all in a long table.
We want to make this a better UX by introducing pagination.
Link to Trello card
https://trello.com/c/4U6IH11x/338-pagination-for-bulk-search
Checklist