Improve bulk search UI #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want the bulk search response to live for as long as someone needs to access it. The approach is based on a typical session window where 30 minutes of inactivity will cause the response to expire. There is a bug in the implementation at the moment where response always expires 30 minutes after it was originally created rather than 30 minutes from when it was last accessed.
The GOVUK pagination component doesn't support being rendered in a tab. I decided to add a new component that wraps the current GOVUK component but overrides the link rendering to include a fragment. This allows the links to use the current tab as part of the URL and navigate the pagination without affecting the tab value.
We want to set expectations around the upload limits.
|
Are there any tests that cover the new pagination case? |
richardpattinson
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can improve the UX of the bulk search experience by adding
new copy and pagination for the not found tab.
Link to Trello card
https://trello.com/c/g08YzsRn/224-bulk-search-stress-test-bulk-search-limits
Checklist