Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a validation for the search limit #852

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Add a validation for the search limit #852

merged 1 commit into from
Sep 26, 2024

Conversation

felixclack
Copy link
Contributor

We want to limit the bulk search to 100 records at a time.

There is no limit on the API side, so I opted to implement this as a
validation before we make the API call.

Link to Trello card

https://trello.com/c/g08YzsRn/224-bulk-search-stress-test-bulk-search-limits

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

We want to limit the bulk search to 100 records at a time.

There is no limit on the API side, so I opted to implement this as a
validation before we make the API call.
Copy link
Contributor

@richardpattinson richardpattinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Happy to merge

@felixclack felixclack merged commit 975eb56 into main Sep 26, 2024
14 checks passed
@felixclack felixclack deleted the bulk-search-limit branch September 26, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants