[2048] Remove app service IP restriction #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saliceti
requested review from
shaheislamdfe
and removed request for
a team
The app service will be accessed by a new front door in s189 after the domain migration. Remove IP restriction to uncouple it from the existing front door.
saliceti
force-pushed
the
2048-aytq-migrate-domains
branch
from
90361e0 to
5284d15
Compare
saliceti
changed the title
shaheislamdfe
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The app service will be accessed by a new front door in s189 after the domain migration.
Changes proposed in this pull request
Remove IP restriction to uncouple it from the existing front door.
Guidance to review
It was removed from preprod manually and https://s165t01-aytq-preprod-app.azurewebsites.net/ does not return 403
After merge
Rules may have to be removed manually
Link to Trello card
https://trello.com/c/kYWAOZTW
Checklist