Add notification banner to inform users of service outage #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpattinson
force-pushed
the
notification-banner-site-disruption
branch
from
81ca7f6 to
1e3ef2b
Compare
felixclack
reviewed
Sep 27, 2024
app/views/layouts/base.html.erb
Outdated
Comment on lines
37
to
39
| <%= render(FlashMessageComponent.new(flash: { | ||
| "info" => ["Scheduled service downtime", "The service will be unavailable on Monday 30th September after 5pm while scheduled upgrades are performed"] | ||
| })) %> |
There was a problem hiding this comment.
This is the wrong component to use. This isn't a flash message.
Just call the govuk_notification_banner method directly. See the docs for details on how to use it.
Also, we should wrap this in a feature flag so we have better control of the visibility.
Suggested change
| <%= render(FlashMessageComponent.new(flash: { | |
| "info" => ["Scheduled service downtime", "The service will be unavailable on Monday 30th September after 5pm while scheduled upgrades are performed"] | |
| })) %> | |
| <% if FeatureFlags::FeatureFlag.active?(:downtime_banner) | |
| <%= govuk_notification_banner title: "Schedule service downtime", text: "The service will be unavailable on Monday 30th September after 5pm while scheduled upgrades are performed" %> | |
| <% end %> |
felixclack
suggested changes
Sep 27, 2024
richardpattinson
force-pushed
the
notification-banner-site-disruption
branch
2 times, most recently
from
ed3abef to
7e35a9b
Compare
felixclack
reviewed
Sep 27, 2024
app/views/layouts/base.html.erb
Outdated
| @@ -34,6 +34,8 @@ | |||
| <%= govuk_back_link(href: yield(:back_link_url)) if content_for?(:back_link_url) %> | |||
| <%= yield(:breadcrumbs) if content_for?(:breadcrumbs) %> | |||
| <main class="govuk-main-wrapper" id="main-content" role="main"> | |||
| <% if FeatureFlags::FeatureFlag.active?(:downtime_banner) %> | |||
| <%= govuk_notification_banner title: "Planned downtime", text: "The service will be unavailable on Monday 30th September between 6pm and 7pm while we carry out essential maintenance" %> <% end %> | |||
There was a problem hiding this comment.
Nit: The end should be on it's own line.
richardpattinson
force-pushed
the
notification-banner-site-disruption
branch
from
7e35a9b to
d02fca6
Compare
felixclack
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As part of the scheduled upgrade to AKS we will need to take the AYTQ/CTR down for an hour. This has been scheduled for monday 30th. A notification banner should be raised to notify users.
Changes proposed in this pull request
Guidance to review
Link to Trello card
Checklist