Update count and restrictions #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixclack
force-pushed
the
fix-bulk-search-count
branch
from
f8b0bf0 to
533a355
Compare
When counting the total number of searched records, we are incorrectly using the paged values. This change ensures we count the total records before applying pagination.
There are cases where a record will have restrictions that we don't want to highlight. We only display the restrictons tag if the code is listed in the `Sanction::SANCTIONS` constant.
felixclack
force-pushed
the
fix-bulk-search-count
branch
from
533a355 to
7a2bde7
Compare
richardpattinson
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA highlighted a couple of issues with the bulk search feature around
the way we count the returned results and also with the restrictions tag.
Link to Trello card
https://trello.com/c/g08YzsRn/224-bulk-search-stress-test-bulk-search-limits
Checklist