Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trial for Clarity #10169

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Trial for Clarity #10169

wants to merge 4 commits into from

Conversation

dcyoung-dev
Copy link
Collaborator

Context

Changes proposed in this pull request

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated.
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

@dcyoung-dev dcyoung-dev added the deploy_v2 Deploy the review app to AKS label Dec 11, 2024
@github-actions github-actions bot temporarily deployed to review_aks-10169 December 11, 2024 16:10 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10169 December 11, 2024 16:27 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10169 December 11, 2024 16:36 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10169 December 11, 2024 16:43 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10169 December 11, 2024 17:03 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant