Don't send request to one login when signing out after impersonation #10194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There is a small bug when login out the candidate using one login. If you logout as a candidate after impersonating the candidate we are sending request to one login to log out.
This is wrong as we didn't log in as a candidate through one login.
This PR fixes this by just redirecting to candidate sign in page if the
id_token
is nill, theid_token
is set in the session only when one login sign in is successfull.Changes proposed in this pull request
Guidance to review
Go on review app and impersonate a candidate user.
Sign out as a candidate user.
You should be redirected to the candidate sign in page.
Things to check