Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[426] part 2 withdrawal reasons feature flag and models #10202

Closed

Conversation

elceebee
Copy link
Contributor

Context

The second of three PRs related to card 426, new withdrawal reasons flow and data model

Changes proposed in this pull request

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated.
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@elceebee elceebee changed the base branch from main to 426-withdrawal-reasons-migrations December 20, 2024 16:24
@elceebee elceebee force-pushed the 426-withdrawal-reasons-migrations branch 2 times, most recently from ed42835 to bc306cb Compare January 2, 2025 13:08
Base automatically changed from 426-withdrawal-reasons-migrations to main January 2, 2025 13:23
@elceebee elceebee force-pushed the 426-part-2-withdrawal-reasons-feature-flag-and-models branch from f0539c7 to 6af5a9a Compare January 2, 2025 13:24
@elceebee elceebee closed this Jan 2, 2025
@elceebee elceebee deleted the 426-part-2-withdrawal-reasons-feature-flag-and-models branch January 2, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant