Remove sprockets #444
Merged
Remove sprockets #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change to Sprockets caused the mere inclusion of sprockets/rails to attempt to initialize the asset pipeline, which depends on the presence of a manifest.js file in app/assets/config. Remove all trace of sprockets and its brethren config.assets (which break unless sprockets/rails is required).
We're never putting this back
tijmenb
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Driven by #442.
Rails 6.0.1 pulls in a newer version of sprockets, which a) we don't use and b) now breaks on initialization because we haven't set it up properly.
Changes proposed in this pull request
Remove Sprockets altogether following advice at rails/sprockets-rails#444
Guidance to review
Confirm it's gone everywhere.