Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement interruption pages for ENIC #9754

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

gms-gs
Copy link
Contributor

@gms-gs gms-gs commented Aug 27, 2024

Context

Ticket: https://trello.com/c/Hj1zFHAV/2052-implement-interruption-pages-for-enic

Expected Behaviour:

If a candidate has selected I am waiting for it to arrive or
I will apply for one in future on any qualification entry page
And they select Review application on an application review page
Then they will see the waiting future variation of the interruption page.

If a candidate has selected I do not need a statement of comparability on all qualification entry page
And they select Review application on an application review page
Then they will see the don’t want variation of the interruption page.

Changes proposed in this pull request

To add a new enic interruption page which appears after the personal statement interruption page. The content will be dynamic depending on which behaviour path is chosen as mentioned above

Guidance to review

  • Add details and do not need a statement of comparability on all qualification
  • The review the application, you should then see the interruption page for that scenario
  • Add details and select I am waiting for it to arrive or I will apply for one in future on any qualification entry page
  • The review the application, you should then see the interruption page for that scenario

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

@gms-gs gms-gs self-assigned this Aug 28, 2024
@gms-gs gms-gs force-pushed the add-enic-interuption-page branch from 07fe142 to 5fbe9a8 Compare August 28, 2024 10:06
@gms-gs gms-gs force-pushed the add-enic-interuption-page branch from 5fbe9a8 to c657fdc Compare August 28, 2024 10:41
@gms-gs
Copy link
Contributor Author

gms-gs commented Aug 28, 2024

@gms-gs gms-gs added the deploy_v2 Deploy the review app to AKS label Aug 28, 2024
Copy link
Contributor

You have one or more flakey tests on this branch! ❄️ ❄️ ❄️

Failed 1 out of 3 times at ./spec/system/provider_interface/change_existing_offer_ske_standard_flow_spec.rb:28: ⚠️ expected to find visible field "Condition 2" that is not disabled with value "A* on Maths A Level" but there were no matches. Also found "Be cool", which matched the selector but not all filters. Expected value to be "A* on Maths A Level" but was "Be cool"

@github-actions github-actions bot temporarily deployed to review_aks-9754 August 28, 2024 10:58 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-9754 August 28, 2024 11:48 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-9754 August 28, 2024 12:36 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-9754 August 28, 2024 12:53 Destroyed
@gms-gs gms-gs marked this pull request as ready for review August 28, 2024 13:00
@github-actions github-actions bot temporarily deployed to review_aks-9754 August 29, 2024 11:08 Destroyed
@gms-gs gms-gs force-pushed the add-enic-interuption-page branch from 7ec2c59 to a030888 Compare August 29, 2024 11:28
@github-actions github-actions bot temporarily deployed to review_aks-9754 August 29, 2024 11:33 Destroyed
@gms-gs gms-gs force-pushed the add-enic-interuption-page branch from a030888 to 0862259 Compare August 29, 2024 12:26
@github-actions github-actions bot temporarily deployed to review_aks-9754 August 29, 2024 12:31 Destroyed
Comment on lines +223 to +225
application_qualifications.count do |qualification|
qualification.enic_reason_waiting? || qualification.enic_reason_maybe?
end >= 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
application_qualifications.count do |qualification|
qualification.enic_reason_waiting? || qualification.enic_reason_maybe?
end >= 1
application_qualifications.filter do |qualification|
qualification.enic_reason_waiting? || qualification.enic_reason_maybe?
end.present?

It's the same thing, but maybe a little easier to read without the >= 1. This is not a blocker. I don't feel strongly about it.

@gms-gs gms-gs force-pushed the add-enic-interuption-page branch from 0862259 to 5cad00b Compare August 29, 2024 13:13
@github-actions github-actions bot temporarily deployed to review_aks-9754 August 29, 2024 13:21 Destroyed
@gms-gs gms-gs force-pushed the add-enic-interuption-page branch 2 times, most recently from 7ad8590 to 6ee337b Compare August 29, 2024 13:22
@gms-gs gms-gs force-pushed the add-enic-interuption-page branch from 6ee337b to a5bfd50 Compare August 29, 2024 13:25
Copy link
Contributor

@elceebee elceebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all my comments!

I have tested this locally with degrees and GCSE qualifications with various responses to the enic qualifications and it is working as anticipated.

@github-actions github-actions bot temporarily deployed to review_aks-9754 August 29, 2024 13:38 Destroyed
@gms-gs gms-gs merged commit 9b69150 into main Aug 29, 2024
60 checks passed
@gms-gs gms-gs deleted the add-enic-interuption-page branch August 29, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants