-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement interruption pages for ENIC #9754
Conversation
07fe142
to
5fbe9a8
Compare
5fbe9a8
to
c657fdc
Compare
You have one or more flakey tests on this branch! ❄️ ❄️ ❄️Failed 1 out of 3 times at ./spec/system/provider_interface/change_existing_offer_ske_standard_flow_spec.rb:28: |
...ndidate_interface/submitting/candidate_submitting_application_with_enic_interruption_spec.rb
Outdated
Show resolved
Hide resolved
...ndidate_interface/submitting/candidate_submitting_application_with_enic_interruption_spec.rb
Outdated
Show resolved
Hide resolved
7ec2c59
to
a030888
Compare
a030888
to
0862259
Compare
app/views/candidate_interface/course_choices/review_enic_interruption/_not_needed.html.erb
Outdated
Show resolved
Hide resolved
app/views/candidate_interface/course_choices/review_enic_interruption/_waiting_maybe.html.erb
Outdated
Show resolved
Hide resolved
application_qualifications.count do |qualification| | ||
qualification.enic_reason_waiting? || qualification.enic_reason_maybe? | ||
end >= 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
application_qualifications.count do |qualification| | |
qualification.enic_reason_waiting? || qualification.enic_reason_maybe? | |
end >= 1 | |
application_qualifications.filter do |qualification| | |
qualification.enic_reason_waiting? || qualification.enic_reason_maybe? | |
end.present? |
It's the same thing, but maybe a little easier to read without the >= 1
. This is not a blocker. I don't feel strongly about it.
app/views/candidate_interface/course_choices/review_enic_interruption/_waiting_maybe.html.erb
Outdated
Show resolved
Hide resolved
0862259
to
5cad00b
Compare
7ad8590
to
6ee337b
Compare
6ee337b
to
a5bfd50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all my comments!
I have tested this locally with degrees and GCSE qualifications with various responses to the enic qualifications and it is working as anticipated.
Context
Ticket: https://trello.com/c/Hj1zFHAV/2052-implement-interruption-pages-for-enic
Expected Behaviour:
If a candidate has selected I am waiting for it to arrive or
I will apply for one in future on any qualification entry page
And they select Review application on an application review page
Then they will see the waiting future variation of the interruption page.
If a candidate has selected I do not need a statement of comparability on all qualification entry page
And they select Review application on an application review page
Then they will see the don’t want variation of the interruption page.
Changes proposed in this pull request
To add a new enic interruption page which appears after the personal statement interruption page. The content will be dynamic depending on which behaviour path is chosen as mentioned above
Guidance to review
Things to check