Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page title not rendering correctly, causing flaky tests #9756

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

elceebee
Copy link
Contributor

Context

We've had a few flaky tests where the page title is being checked. They are flaky when the Faker data provides a name that has an apostrophe or other character in it.

Changes proposed in this pull request

Add html_safe to browser title so the characters will be renedered.

Before After
image image

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

@elceebee elceebee changed the title Assume browser titles are html safe Fix page title not rendering correctly, causing flaky tests Aug 28, 2024
@elceebee elceebee marked this pull request as ready for review August 28, 2024 07:28
@elceebee elceebee requested a review from a team August 28, 2024 07:28
@elceebee elceebee merged commit 2a2c8e5 into main Aug 28, 2024
23 checks passed
@elceebee elceebee deleted the fix-page-title-not-rendering-some-characters branch August 28, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants