Skip school selection in CourseSelection based on Provider#selectable_school

[inulty-dfe]

Context

Starting in the 2025 Recruitment Cycle we will be hiding the CourseSiteStep (picking a placement school) in the CourseSelectionWizard for certain providers.
For these providers' courses, we will automatically choose a placement school. This happens already if the provider has only one placement school.
We will also hide the Location row of the Application Review component if we have automatically selected a School.

Changes proposed in this pull request

1. Automatically choose a placement school unless the provider is selectable_school.
2. Enable the feature to be enabled only after the 2024 recruitment cycle
3. Set ApplicationChoice#school_placement_auto_selected for applications to providers that have selectable_school set to false.
4. Hide the Location row in the Course Review if the School was automatically selected

Guidance to review

1. Selectable school factory defaults
   Q: Should factories reflect the most common conditions or the most complex conditions by default?
   For example, adding selectable_school to Provider.
   In production the default will be false.
   99%+ providers will have this as false.
   This makes the Course selection journey simpler. But it also means we have to set selectable_school to true if we want to test existing examples.
   Would you set the factory by default to true or false

2. Whats the best way to clean up the recruitment cycle check for enabling the feature?

Testing

The environment is already set up to after apply opens in 2025.

Provider	id	course	selectable_school	sites
NIoT@Harris Initial Teacher Education	16	any	true	many
Keele and North Staffordshire Teacher Education (24J)	3	Primary (3-7) (2Q5R)	false	3

Video

As described above, Harris is selectable_school true and Keele is selectable_school false

selectable_school-2025.webm

Things to check

• If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
• This code does not rely on migrations in the same Pull Request
• If this code includes a migration adding or changing columns, it also backfills existing records for consistency
• If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
• API release notes have been updated if necessary
• If it adds a significant user-facing change, is it documented in the CHANGELOG?
• Required environment variables have been updated added to the Azure KeyVault
• Inform data insights team due to database changes
• Make sure all information from the Trello card is in here
• Rebased main
• Cleaned commit history
• Tested by running locally
• Add PR link to Trello card

[inulty-dfe]

This is a bug fix.

We get silent exception.

When we try to instantiate the next step and call next_step on that (to know if there is a next step) we get errors about the params required to create the next - next step.

This was originally designed to avoid having to list all the steps we know do not have a next step.

We now revert to doing that out of necessity. Description added to the commit message also.

[inulty-dfe]

Ideally "terminal" or "editable" steps should have a property so we can identify them.

class ThingStep < DfE::Wizard::Step

  def self.terminal
    true
  end

...

return next_step_path(next_step_klass) unless next_step_klass.terminal?

@tomas-stefano

[tomas-stefano]

I try to read and read and I don't understand to be fair. 🤔

Let's huddle in the afternoon?

[github-actions]

You have one or more flakey tests on this branch! ❄️ ❄️ ❄️

Failed 1 out of 3 times at ./spec/system/provider_interface/change_existing_offer_ske_standard_flow_spec.rb:28: ⚠️ expected to find visible field "Condition 2" that is not disabled with value "A* on Maths A Level" but there were no matches. Also found "Be cool", which matched the selector but not all filters. Expected value to be "A* on Maths A Level" but was "Be cool"

[inulty-dfe]

Skip school selection in CourseSelection based on Provider#selectable school

[CatalinVoineag]

Tested this on review, works as expected. Thanks for the video, that helped 👍🏻

[github-actions]

You have one or more flakey tests on this branch! ❄️ ❄️ ❄️

Failed 1 out of 3 times at ./spec/system/candidate_interface/carry_over/candidate_carries_over_after_rejecting_offer_between_cycles_spec.rb:6: ⚠️ Ambiguous match, found 2 elements matching visible link or button "West Gutkowski College"

[github-actions]

You have one or more flakey tests on this branch! ❄️ ❄️ ❄️

Failed 1 out of 3 times at ./spec/system/candidate_interface/course_selection/candidate_deletes_application_spec.rb:6: ⚠️ Ambiguous match, found 2 elements matching visible link or button "Boyle University"