Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reopen banner with new content #9761

Conversation

elceebee
Copy link
Contributor

@elceebee elceebee commented Aug 28, 2024

Context

Some content changes to the banner we show candidates after the apply deadline has passed.

Changes proposed in this pull request

Before After
image image

Guidance to review

Can be viewed locally or on the review app at /rails/view_components/candidate_interface/reopen_banner_alert/reopen_banner_component

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

@elceebee
Copy link
Contributor Author

@elceebee elceebee added the deploy_v2 Deploy the review app to AKS label Aug 28, 2024
@elceebee elceebee self-assigned this Aug 28, 2024
@elceebee elceebee requested a review from a team August 28, 2024 14:14
@elceebee elceebee marked this pull request as ready for review August 28, 2024 14:14
@github-actions github-actions bot temporarily deployed to review_aks-9761 August 28, 2024 14:17 Destroyed
Copy link
Contributor

You have one or more flakey tests on this branch! ❄️ ❄️ ❄️

Failed 1 out of 3 times at ./spec/system/provider_interface/change_existing_offer_ske_standard_flow_spec.rb:28: ⚠️ expected to find visible field "Condition 2" that is not disabled with value "A* on Maths A Level" but there were no matches. Also found "Be cool", which matched the selector but not all filters. Expected value to be "A* on Maths A Level" but was "Be cool"

@github-actions github-actions bot temporarily deployed to review_aks-9761 August 28, 2024 14:28 Destroyed
@elceebee elceebee force-pushed the 2225-review-and-update-apply-banner-applications-for-courses-are-closed branch from 62dadc3 to cef5697 Compare August 28, 2024 15:30
@github-actions github-actions bot temporarily deployed to review_aks-9761 August 28, 2024 15:35 Destroyed
@elceebee elceebee force-pushed the 2225-review-and-update-apply-banner-applications-for-courses-are-closed branch from cef5697 to 076d6c9 Compare August 28, 2024 16:40
@github-actions github-actions bot temporarily deployed to review_aks-9761 August 28, 2024 16:44 Destroyed
@elceebee elceebee merged commit 960fedd into main Aug 29, 2024
23 checks passed
@elceebee elceebee deleted the 2225-review-and-update-apply-banner-applications-for-courses-are-closed branch August 29, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants