Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug party review app - after apply deadline - DO NOT MERGE #9766

Closed
wants to merge 1 commit into from

Conversation

elceebee
Copy link
Contributor

@elceebee elceebee commented Aug 29, 2024

Context

This is a review app for the bug party on Monday 2 September, testing the candidate and provider experiences immediately after the apply deadline.

This PR is not for merging

Changes proposed in this pull request

Temporarily commenting out some conditions so I can easily run end-of-cycle related jobs.

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

@elceebee elceebee added the deploy_v2 Deploy the review app to AKS label Aug 29, 2024
@elceebee elceebee self-assigned this Aug 29, 2024
@github-actions github-actions bot temporarily deployed to review_aks-9766 August 29, 2024 14:30 Destroyed
@elceebee elceebee changed the title temporarily remove conditions so we can run jobs in test environments Bug party review app - after apply deadline - DO NOT MERGE Aug 29, 2024
@github-actions github-actions bot temporarily deployed to review_aks-9766 August 29, 2024 14:50 Destroyed
@elceebee elceebee closed this Aug 30, 2024
@elceebee elceebee deleted the after-apply-deadline-review-app branch September 20, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant