Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SetSelectableSchoolsOnProviders DataMigration #9767

Conversation

inulty-dfe
Copy link
Collaborator

@inulty-dfe inulty-dfe commented Aug 29, 2024

Context

Add a DataMigration to update specific providers by setting selectable_school to true.

Changes proposed in this pull request

Add DataMigration
Select the Providers by their Code
The source of the list of codes is in a CSV attached to the trello ticket.
Tested locally

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

  Update specific providers by setting selectable_school to true.
@inulty-dfe inulty-dfe requested a review from a team August 29, 2024 16:03
@inulty-dfe inulty-dfe marked this pull request as ready for review August 29, 2024 16:03
@inulty-dfe
Copy link
Collaborator Author

Wrong repo, should be in Publish

@inulty-dfe inulty-dfe closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant