Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow candidate to edit work histories #9781

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

CatalinVoineag
Copy link
Contributor

@CatalinVoineag CatalinVoineag commented Sep 2, 2024

Context

We want to allow the candidate to edit their work histories, this will only edit work experiences, volunteering_experiences and work history breaks on the application form.

The application choices that are submitted will still have the old work histories. This is because each submitted application choice has its own work history.

So the user will be able to edit their work histories but only for new application choices.

Changes proposed in this pull request

Added work_history and volunteering to config/application, to allow them to be editable here

all.select { |section| section.id.in?(Rails.application.config.x.sections.editable) }

Guidance to review

Go on review and edit an application form's work experiences. The form needs to have choices submitted

Screencast.2024-09-24.15.44.45.mp4

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

@CatalinVoineag CatalinVoineag self-assigned this Sep 2, 2024
@CatalinVoineag CatalinVoineag force-pushed the cv/allow-work-history-edits branch from fbdb1f2 to 6e45d4a Compare September 3, 2024 09:01
@CatalinVoineag CatalinVoineag force-pushed the cv/allow-work-history-edits branch from 6e45d4a to dc4443a Compare September 24, 2024 12:41
@CatalinVoineag CatalinVoineag force-pushed the cv/allow-work-history-edits branch from dc4443a to 7d5be4e Compare September 24, 2024 13:42
@CatalinVoineag CatalinVoineag added the deploy_v2 Deploy the review app to AKS label Sep 24, 2024
@github-actions github-actions bot temporarily deployed to review_aks-9781 September 24, 2024 14:07 Destroyed
@CatalinVoineag CatalinVoineag force-pushed the cv/allow-work-history-edits branch from 7d5be4e to 35c28a5 Compare September 24, 2024 15:05
@github-actions github-actions bot temporarily deployed to review_aks-9781 September 24, 2024 15:17 Destroyed
@CatalinVoineag CatalinVoineag marked this pull request as ready for review September 24, 2024 15:36
@CatalinVoineag
Copy link
Contributor Author

@CatalinVoineag CatalinVoineag requested a review from a team September 24, 2024 15:41
Copy link
Collaborator

@dcyoung-dev dcyoung-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. I don't love checking the controllers to determine actions but it's what we've done elsewhere and there's no need to reinvent the wheel.
It's worth getting as many eyes on this as possible as well as some review app action from people 👌

Copy link
Collaborator

@inulty-dfe inulty-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The candidate cannot see the previously submitted versions of their work history. They can see their personal statement

Copy link
Contributor

@elceebee elceebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this on the review app, adding experiences and submitted applications. New experiences are only included in subsequent application choices, so everything works as expected. Nice work!

@github-actions github-actions bot temporarily deployed to review_aks-9781 September 26, 2024 09:28 Destroyed
@CatalinVoineag
Copy link
Contributor Author

CatalinVoineag commented Sep 26, 2024

The candidate cannot see the previously submitted versions of their work history. They can see their personal statement

Good spot. This will come in the future, we want to redesign this candidate application_choice show page to show all the information sent to provider but for now we will just enable the feature.

We want to allow the candidate to edit their work histories, this will
only edit work experiences, volunteering_experiences and work history
breaks on the application form.

The application choices that are submitted will still have the old work
histories. This is because each submitted application choice has its own
work history.

So the user will be able to edit their work histories but only for new
application choices.
@github-actions github-actions bot temporarily deployed to review_aks-9781 September 26, 2024 09:53 Destroyed
@CatalinVoineag CatalinVoineag merged commit cc43927 into main Sep 26, 2024
59 checks passed
@CatalinVoineag CatalinVoineag deleted the cv/allow-work-history-edits branch September 26, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants