-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow candidate to edit work histories #9781
Conversation
fbdb1f2
to
6e45d4a
Compare
6e45d4a
to
dc4443a
Compare
dc4443a
to
7d5be4e
Compare
7d5be4e
to
35c28a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great. I don't love checking the controllers to determine actions but it's what we've done elsewhere and there's no need to reinvent the wheel.
It's worth getting as many eyes on this as possible as well as some review app action from people 👌
config/locales/components/candidate_interface/editable_section_warning.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The candidate cannot see the previously submitted versions of their work history. They can see their personal statement
app/components/candidate_interface/editable_section_warning.html.erb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this on the review app, adding experiences and submitted applications. New experiences are only included in subsequent application choices, so everything works as expected. Nice work!
Good spot. This will come in the future, we want to redesign this candidate application_choice show page to show all the information sent to provider but for now we will just enable the feature. |
We want to allow the candidate to edit their work histories, this will only edit work experiences, volunteering_experiences and work history breaks on the application form. The application choices that are submitted will still have the old work histories. This is because each submitted application choice has its own work history. So the user will be able to edit their work histories but only for new application choices.
d8368ef
to
b7ca3bc
Compare
Context
We want to allow the candidate to edit their work histories, this will only edit work experiences, volunteering_experiences and work history breaks on the application form.
The application choices that are submitted will still have the old work histories. This is because each submitted application choice has its own work history.
So the user will be able to edit their work histories but only for new application choices.
Changes proposed in this pull request
Added
work_history
andvolunteering
to config/application, to allow them to be editable hereapply-for-teacher-training/app/services/section.rb
Line 80 in 2e4d5b9
Guidance to review
Go on review and edit an application form's work experiences. The form needs to have choices submitted
Screencast.2024-09-24.15.44.45.mp4
Things to check