Delete unwanted audits

app/services/data_migrations/delete_work_history_audits.rb

@@ -0,0 +1,24 @@
+module DataMigrations
+  class DeleteWorkHistoryAudits
+    TIMESTAMP = 20240917154444
+    MANUAL_RUN = false
+    BATCH_SIZE = 5000
+
+    def change
+      relation.in_batches(of: BATCH_SIZE) do |batch|
+        DeleteAuditsWorker.perform_async(batch.ids)
+      end
+    end
+
+    def relation
+      Audited::Audit
+        .where('created_at >= ? and created_at <= ?', DateTime.new(2024, 9, 3, 11), DateTime.new(2024, 9, 3, 20))
+        .where(user_type: nil, user_id: nil)
+        .where(action: :create)
+        .where(username: '(Automated process)')
+        .where(associated_type: 'ApplicationChoice')
+        .where(auditable_type: %w[ApplicationExperience ApplicationWorkHistoryBreak])
+        .order(id: :asc)
+    end
+  end
+end

app/workers/delete_audits_worker.rb

@@ -0,0 +1,8 @@
+class DeleteAuditsWorker
+  include Sidekiq::Worker
+  sidekiq_options queue: :low_priority
+
+  def perform(audit_ids)
+    Audited::Audit.where(id: audit_ids).delete_all
+  end
+end

lib/tasks/data.rake

@@ -5,6 +5,7 @@ DATA_MIGRATION_SERVICES = [
   'DataMigrations::BackfillWithdrawalReasons',
   'DataMigrations::RemoveTeacherDegreeApprenticeshipFeatureFlag',
   'DataMigrations::RevertApplicationChoicesUpdatedAt',
+  'DataMigrations::DeleteWorkHistoryAudits',
   'DataMigrations::BackfillApplicationChoicesWithWorkExperiences',
   'DataMigrations::MarkUnsubmittedApplicationsWithoutEnglishProficiencyAsElfIncomplete',
   'DataMigrations::BackfillEnglishProficiencyRecordsForCarriedOverApplications',

spec/factories/audit.rb

@@ -9,7 +9,7 @@
     created_at { Time.zone.now }
 
     transient do
-      application_experience { build_stubbed(:application_experience) }
+      application_experience { build_stubbed(:application_work_experience) }
       application_choice { build_stubbed(:application_choice, :awaiting_provider_decision) }
       changes { {} }
     end
@@ -18,7 +18,7 @@
       audit.auditable_type = 'ApplicationExperience'
       audit.auditable_id = evaluator.application_experience.id
       audit.associated = evaluator.application_choice
-      audit.user_type = evaluator.user.class.to_s
+      audit.user_type = evaluator.user.class.to_s unless evaluator.username == '(Automated process)'
       audit.audited_changes = evaluator.changes
     end
   end
@@ -40,7 +40,7 @@
       audit.auditable_type = 'ApplicationWorkHistoryBreak'
       audit.auditable_id = evaluator.application_work_history_break.id
       audit.associated = evaluator.application_choice
-      audit.user_type = evaluator.user.class.to_s
+      audit.user_type = evaluator.user.class.to_s unless evaluator.username == '(Automated process)'
       audit.audited_changes = evaluator.changes
     end
   end

spec/services/data_migrations/delete_work_history_audits_spec.rb

@@ -0,0 +1,101 @@
+require 'rails_helper'
+
+RSpec.describe DataMigrations::DeleteWorkHistoryAudits do
+  describe '#change' do
+    it 'enques jobs to DeleteAuditsWorker' do
+      create(
+        :application_work_history_break_audit,
+        user_type: nil,
+        user_id: nil,
+        created_at: DateTime.new(2024, 9, 3, 12),
+        action: 'create',
+        username: '(Automated process)',
+      )
+
+      expect { described_class.new.change }.to change(
+        DeleteAuditsWorker.jobs, :size
+      ).by(1)
+    end
+  end
+
+  describe '#relation' do
+    it 'returns the audits that need deleting' do
+      work_break = create(
+        :application_work_history_break_audit,
+        action: 'create',
+        user_type: nil,
+        user_id: nil,
+        username: '(Automated process)',
+        created_at: DateTime.new(2024, 9, 3, 12),
+      )
+      work_break_2 = create(
+        :application_work_history_break_audit,
+        action: 'create',
+        user_type: nil,
+        user_id: nil,
+        username: '(Automated process)',
+        created_at: DateTime.new(2024, 9, 3, 18),
+      )
+      work_experience = create(
+        :application_experience_audit,
+        action: 'create',
+        user_type: nil,
+        user_id: nil,
+        username: '(Automated process)',
+        created_at: DateTime.new(2024, 9, 3, 18),
+      )
+      work_break_with_provider_username = create(
+        :application_work_history_break_audit,
+        action: 'create',
+        username: 'Provider',
+      )
+      work_break_with_update_action = create(
+        :application_work_history_break_audit,
+        action: 'update',
+        username: '(Automated process)',
+        user_type: nil,
+        user_id: nil,
+      )
+      work_break_outside_time_range = create(
+        :application_work_history_break_audit,
+        action: 'create',
+        username: '(Automated process)',
+        user_type: nil,
+        user_id: nil,
+        created_at: DateTime.new(2024, 9, 4, 18),
+      )
+      work_break_with_provider_user_type = create(
+        :application_work_history_break_audit,
+        action: 'create',
+        username: '(Automated process)',
+        created_at: DateTime.new(2024, 9, 3, 18),
+        user_type: 'Provider',
+      )
+      work_experience_outside_time_range = create(
+        :application_experience_audit,
+        action: 'create',
+        user_type: nil,
+        user_id: nil,
+        created_at: DateTime.new(2024, 9, 4, 18),
+      )
+      application_form_audit = create(
+        :application_form_audit,
+        action: 'create',
+        user_type: nil,
+        user_id: nil,
+        username: '(Automated process)',
+        created_at: DateTime.new(2024, 9, 3, 12),
+      )
+
+      expect(described_class.new.relation).to include(work_break, work_break_2, work_experience)
+      expect(described_class.new.relation).not_to include(
+        work_break_with_provider_username,
+        work_break_with_update_action,
+        work_break_outside_time_range,
+        work_break_with_provider_user_type,
+        work_experience_outside_time_range,
+        application_form_audit,
+      )
+    end
+  end
+end

spec/workers/delete_audits_worker_spec.rb

@@ -0,0 +1,17 @@
+require 'rails_helper'
+
+RSpec.describe DeleteAuditsWorker do
+  describe '#perform' do
+    it 'deletes audits by id' do
+      audit_1 = create(:application_work_history_break_audit)
+      audit_2 = create(:application_work_history_break_audit)
+      audit_3 = create(:application_work_history_break_audit)
+      audit_ids = [audit_1.id, audit_2.id]
+
+      described_class.new.perform(audit_ids)
+
+      expect(Audited::Audit.where(id: audit_ids)).not_to exist
+      expect(Audited::Audit.where(id: audit_3.id)).to exist
+    end
+  end
+end