Make sure degree requirements row doesn't appear for undergraduate #9845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If candidate is applying for undergraduate they should not see the degree requirements row no matter how bad the data is on the course.
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
tomas-stefano
commented
Sep 18, 2024
app/components/candidate_interface/course_choices_review_component.rb
Outdated
Show resolved
Hide resolved
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
avinhurry
reviewed
Sep 19, 2024
app/components/candidate_interface/course_choices_review_component.rb
Outdated
Show resolved
Hide resolved
spec/components/candidate_interface/course_review_component_spec.rb
Outdated
Show resolved
Hide resolved
spec/components/candidate_interface/course_review_component_spec.rb
Outdated
Show resolved
Hide resolved
…ec.rb Co-authored-by: avinhurry <[email protected]>
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
elceebee
approved these changes
Sep 19, 2024
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
tomas-stefano
deleted the
2302-tda-apply-ensure-degree-required-information-doesnt-appear-on-undergraduate
branch
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
If candidate is applying for undergraduate they should not see the degree requirements row no matter how bad the data is on the course.
Changes proposed in this pull request
Guidance to review