Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE Review app for 23 September Bug Party #9847

Closed
wants to merge 3 commits into from

Conversation

elceebee
Copy link
Contributor

Context

Changes proposed in this pull request

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

@elceebee elceebee added DO NOT MERGE deploy_v2 Deploy the review app to AKS labels Sep 18, 2024
@elceebee elceebee self-assigned this Sep 18, 2024
@elceebee elceebee changed the title Review app for 23 September Bug Party DO NOT MERGE Review app for 23 September Bug Party Sep 18, 2024
@github-actions github-actions bot temporarily deployed to review_aks-9847 September 18, 2024 15:36 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-9847 September 18, 2024 15:48 Destroyed
@elceebee elceebee force-pushed the 2327-end-of-cycle-bug-party branch from fbed7b2 to 8a55ad2 Compare September 20, 2024 08:57
@github-actions github-actions bot temporarily deployed to review_aks-9847 September 20, 2024 09:03 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-9847 September 20, 2024 09:16 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-9847 September 20, 2024 10:44 Destroyed
@elceebee elceebee force-pushed the 2327-end-of-cycle-bug-party branch from 616432c to 1d48157 Compare September 20, 2024 15:26
@github-actions github-actions bot temporarily deployed to review_aks-9847 September 20, 2024 15:31 Destroyed
@elceebee elceebee closed this Sep 23, 2024
@elceebee elceebee deleted the 2327-end-of-cycle-bug-party branch October 3, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant