Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the offer email to include "mandatory checks" information #9859

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

gms-gs
Copy link
Contributor

@gms-gs gms-gs commented Sep 23, 2024

Context

We have removed the ‘other requirements’ field from Publish and Find but we still need to tell candidates about the mandatory checks that they need to pass before they can accept an offer.

One place we can include this information is the email a candidate receives when they receive an offer.

Changes proposed in this pull request

Update content for the /rails/mailers/candidate_mailer/new_offer_made email

Guidance to review

Review screenshot below
Screenshot 2024-09-23 at 07 40 57

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

@gms-gs gms-gs added the deploy_v2 Deploy the review app to AKS label Sep 23, 2024
@gms-gs gms-gs changed the title Update content Update the offer email to include "mandatory checks" information Sep 23, 2024
@github-actions github-actions bot temporarily deployed to review_aks-9859 September 23, 2024 07:00 Destroyed
@gms-gs gms-gs force-pushed the update-new-offer-made-email-content branch from dd047ce to 227dbb2 Compare September 23, 2024 07:11
@github-actions github-actions bot temporarily deployed to review_aks-9859 September 23, 2024 07:16 Destroyed
@gms-gs gms-gs force-pushed the update-new-offer-made-email-content branch from 227dbb2 to 697fae5 Compare September 23, 2024 07:20
@gms-gs gms-gs marked this pull request as ready for review September 23, 2024 07:21
@github-actions github-actions bot temporarily deployed to review_aks-9859 September 23, 2024 07:30 Destroyed
@gms-gs
Copy link
Contributor Author

gms-gs commented Sep 23, 2024

@gms-gs gms-gs force-pushed the update-new-offer-made-email-content branch from 697fae5 to e995567 Compare September 23, 2024 12:03
@gms-gs gms-gs requested a review from elceebee September 23, 2024 12:04
@gms-gs gms-gs force-pushed the update-new-offer-made-email-content branch from bccf7d2 to 28bb620 Compare September 23, 2024 12:06
@github-actions github-actions bot temporarily deployed to review_aks-9859 September 23, 2024 12:08 Destroyed
Copy link
Contributor

@elceebee elceebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving the things I raised.

@github-actions github-actions bot temporarily deployed to review_aks-9859 September 23, 2024 12:23 Destroyed
Copy link
Contributor

You have one or more flakey tests on this branch! ❄️ ❄️ ❄️

Failed 1 out of 3 times at ./spec/system/provider_interface/provider_removes_conditions_from_an_offer_spec.rb:8: ⚠️ expected not to find text "Ipsum enim vel in." in "Cookies on Manage teacher training applications We use some essential cookies to make this service work. We’d also like to use analytics cookies so we can understand how you use the service and make improvements. Accept analytics cookies Reject analytics cookies View cookies Skip to main content GOV.UK Organisation settings Your account Sign out Test Applications Interview schedule Reports Activity log Back Update offer - John Smith Check and send new offer Course details Training provider Eastern Barton Institute-21 (ZD0) Course Arts (TASY) Full time or part time Full time Location Ironbarrow Secondary College 605 441 Tonja Mountain Albertfort Cambridgeshire TE1W 2LA Qualification QTS with PGCE Funding type Apprenticeship Conditions of offer Candidates are required to receive 2 references. Add or change conditions Ipsum enim vel in. Pending Send new offer Cancel Get help Email [email protected] You will get a response within 5 working days, or one working day for urgent requests. Support links How to use this service Changes to this service Accessibility Cookies Privacy Guidance for using AI © Crown copyright"

Copy link
Contributor

You have one or more flakey tests on this branch! ❄️ ❄️ ❄️

Failed 1 out of 3 times at ./spec/system/provider_interface/provider_removes_conditions_from_an_offer_spec.rb:8: ⚠️ expected not to find text "Ipsum enim vel in." in "Cookies on Manage teacher training applications We use some essential cookies to make this service work. We’d also like to use analytics cookies so we can understand how you use the service and make improvements. Accept analytics cookies Reject analytics cookies View cookies Skip to main content GOV.UK Organisation settings Your account Sign out Test Applications Interview schedule Reports Activity log Back Update offer - John Smith Check and send new offer Course details Training provider Eastern Barton Institute-21 (ZD0) Course Arts (TASY) Full time or part time Full time Location Ironbarrow Secondary College 605 441 Tonja Mountain Albertfort Cambridgeshire TE1W 2LA Qualification QTS with PGCE Funding type Apprenticeship Conditions of offer Candidates are required to receive 2 references. Add or change conditions Ipsum enim vel in. Pending Send new offer Cancel Get help Email [email protected] You will get a response within 5 working days, or one working day for urgent requests. Support links How to use this service Changes to this service Accessibility Cookies Privacy Guidance for using AI © Crown copyright"

1 similar comment
Copy link
Contributor

You have one or more flakey tests on this branch! ❄️ ❄️ ❄️

Failed 1 out of 3 times at ./spec/system/provider_interface/provider_removes_conditions_from_an_offer_spec.rb:8: ⚠️ expected not to find text "Ipsum enim vel in." in "Cookies on Manage teacher training applications We use some essential cookies to make this service work. We’d also like to use analytics cookies so we can understand how you use the service and make improvements. Accept analytics cookies Reject analytics cookies View cookies Skip to main content GOV.UK Organisation settings Your account Sign out Test Applications Interview schedule Reports Activity log Back Update offer - John Smith Check and send new offer Course details Training provider Eastern Barton Institute-21 (ZD0) Course Arts (TASY) Full time or part time Full time Location Ironbarrow Secondary College 605 441 Tonja Mountain Albertfort Cambridgeshire TE1W 2LA Qualification QTS with PGCE Funding type Apprenticeship Conditions of offer Candidates are required to receive 2 references. Add or change conditions Ipsum enim vel in. Pending Send new offer Cancel Get help Email [email protected] You will get a response within 5 working days, or one working day for urgent requests. Support links How to use this service Changes to this service Accessibility Cookies Privacy Guidance for using AI © Crown copyright"

@github-actions github-actions bot temporarily deployed to review_aks-9859 September 23, 2024 12:49 Destroyed
@gms-gs gms-gs merged commit 99d63dd into main Sep 23, 2024
59 checks passed
@gms-gs gms-gs deleted the update-new-offer-made-email-content branch September 23, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants