-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the offer email to include "mandatory checks" information #9859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gms-gs
changed the title
Update content
Update the offer email to include "mandatory checks" information
Sep 23, 2024
gms-gs
force-pushed
the
update-new-offer-made-email-content
branch
from
September 23, 2024 07:11
dd047ce
to
227dbb2
Compare
gms-gs
force-pushed
the
update-new-offer-made-email-content
branch
from
September 23, 2024 07:20
227dbb2
to
697fae5
Compare
avinhurry
approved these changes
Sep 23, 2024
elceebee
reviewed
Sep 23, 2024
elceebee
reviewed
Sep 23, 2024
gms-gs
force-pushed
the
update-new-offer-made-email-content
branch
from
September 23, 2024 12:03
697fae5
to
e995567
Compare
gms-gs
force-pushed
the
update-new-offer-made-email-content
branch
from
September 23, 2024 12:06
bccf7d2
to
28bb620
Compare
elceebee
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for resolving the things I raised.
You have one or more flakey tests on this branch! ❄️ ❄️ ❄️Failed 1 out of 3 times at ./spec/system/provider_interface/provider_removes_conditions_from_an_offer_spec.rb:8: |
You have one or more flakey tests on this branch! ❄️ ❄️ ❄️Failed 1 out of 3 times at ./spec/system/provider_interface/provider_removes_conditions_from_an_offer_spec.rb:8: |
1 similar comment
You have one or more flakey tests on this branch! ❄️ ❄️ ❄️Failed 1 out of 3 times at ./spec/system/provider_interface/provider_removes_conditions_from_an_offer_spec.rb:8: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have removed the ‘other requirements’ field from Publish and Find but we still need to tell candidates about the mandatory checks that they need to pass before they can accept an offer.
One place we can include this information is the email a candidate receives when they receive an offer.
Changes proposed in this pull request
Update content for the
/rails/mailers/candidate_mailer/new_offer_made
emailGuidance to review
Review screenshot below
Things to check