Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Party take 2 DO NOT MERGE #9864

Closed
wants to merge 2 commits into from
Closed

Conversation

elceebee
Copy link
Contributor

Context

Changes proposed in this pull request

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

@elceebee elceebee added the deploy_v2 Deploy the review app to AKS label Sep 23, 2024
@github-actions github-actions bot temporarily deployed to review_aks-9864 September 23, 2024 15:18 Destroyed
@elceebee elceebee changed the title temporarily allowing us to force job to create data for review app Bug Party take 2 DO NOT MERGE Sep 24, 2024
@github-actions github-actions bot temporarily deployed to review_aks-9864 September 24, 2024 08:29 Destroyed
Copy link
Contributor

You have one or more flakey tests on this branch! ❄️ ❄️ ❄️

Failed 1 out of 3 times at ./spec/system/provider_interface/provider_removes_conditions_from_an_offer_spec.rb:8: ⚠️ expected not to find text "Molestiae rem consequatur fugiat." in "Cookies on Manage teacher training applications We use some essential cookies to make this service work. We’d also like to use analytics cookies so we can understand how you use the service and make improvements. Accept analytics cookies Reject analytics cookies View cookies Skip to main content GOV.UK Organisation settings Your account Sign out Test Applications Interview schedule Reports Activity log Back Update offer - John Smith Check and send new offer Course details Training provider Turcotte University-7 (GO4) Course Psychology (BK7W) Full time or part time Full time Location Mallowtown Secondary College 226 45126 Dwayne Oval South Steve Borders W9 4XW Qualification QTS with PGCE Funding type Fee Conditions of offer Candidates are required to receive 2 references. Add or change conditions Molestiae rem consequatur fugiat. Pending Send new offer Cancel Get help Email [email protected] You will get a response within 5 working days, or one working day for urgent requests. Support links How to use this service Changes to this service Accessibility Cookies Privacy Guidance for using AI © Crown copyright"

@elceebee elceebee force-pushed the v2-2327-end-of-cycle-bug-party branch from 14ca455 to d2ca482 Compare September 24, 2024 13:16
@github-actions github-actions bot temporarily deployed to review_aks-9864 September 24, 2024 13:21 Destroyed
@elceebee elceebee force-pushed the v2-2327-end-of-cycle-bug-party branch from d2ca482 to 6adefff Compare September 26, 2024 14:16
@github-actions github-actions bot temporarily deployed to review_aks-9864 September 26, 2024 14:23 Destroyed
@elceebee elceebee closed this Oct 3, 2024
@elceebee elceebee deleted the v2-2327-end-of-cycle-bug-party branch October 3, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant