[2315] Bug - Decline by default at date set incorrectly in application

app/services/data_migrations/set_decline_by_default_at_and_decline_by_default_days_to_nil.rb

@@ -0,0 +1,28 @@
+module DataMigrations
+  class SetDeclineByDefaultAtAndDeclineByDefaultDaysToNil
+    TIMESTAMP = 20240925092609
+    MANUAL_RUN = true
+
+    def change
+      application_choices.in_batches(of: 4000) do |batch|
+        batch.update_all(decline_by_default_at: nil, decline_by_default_days: nil)
+      end
+    end
+
+  private
+
+    def application_choices
+      choices_from_2024
+        .where.not(decline_by_default_at: nil)
+        .or(choices_from_2024.where.not(decline_by_default_days: nil))
+        .distinct
+    end
+
+    def choices_from_2024
+      @choices_from_2024 ||= ApplicationChoice
+                               .joins(:application_form)
+                               .where('application_form.recruitment_cycle_year': 2024)
+                               .distinct
+    end
+  end
+end

lib/tasks/data.rake

@@ -1,5 +1,6 @@
 DATA_MIGRATION_SERVICES = [
   # do not delete or edit this line - services added below by generator
+  'DataMigrations::SetDeclineByDefaultAtAndDeclineByDefaultDaysToNil',
   'DataMigrations::BackfillApplicationChoicesWithWorkExperiences',
   'DataMigrations::MarkUnsubmittedApplicationsWithoutEnglishProficiencyAsElfIncomplete',
   'DataMigrations::BackfillEnglishProficiencyRecordsForCarriedOverApplications',
@@ -19,8 +20,6 @@ DATA_MIGRATION_SERVICES = [
   'DataMigrations::RemoveFeedbackHelpfulFeatureFlag',
   'DataMigrations::RemoveOnePersonalStatementFeatureFlag',
   'DataMigrations::SetMissingWorkHistoryStatusValues',
-  'DataMigrations::UpdateDeclineByDefaultAtFromCurrentCycle',
-  'DataMigrations::RemoveDbdFromCurrentCycle',
   'DataMigrations::RemoveRecruitWithPendingConditionsFeatureFlag',
   'DataMigrations::BackfillFeedbackFormComplete',
   'DataMigrations::RemoveMidCycleReportFeatureFlag',

spec/services/data_migrations/set_decline_by_default_at_and_decline_by_default_days_to_nil_spec.rb

@@ -0,0 +1,49 @@
+require 'rails_helper'
+
+RSpec.describe DataMigrations::SetDeclineByDefaultAtAndDeclineByDefaultDaysToNil do
+  it 'updates choices where decline_by_default_at is not null' do
+    application_choice = create(:application_choice,
+                                decline_by_default_at: DateTime.now,
+                                decline_by_default_days: nil,
+                                application_form: build(:application_form, recruitment_cycle_year: 2024))
+
+    described_class.new.change
+    expect(application_choice.reload.decline_by_default_at).to be_nil
+  end
+
+  it 'updates choices where decline_by_default_days is not null' do
+    application_choice = create(:application_choice,
+                                decline_by_default_at: nil,
+                                decline_by_default_days: 10,
+                                application_form: build(:application_form, recruitment_cycle_year: 2024))
+
+    described_class.new.change
+
+    expect(application_choice.reload.decline_by_default_days).to be_nil
+  end
+
+  it 'updates choices where both days and at are not null' do
+    application_choice = create(:application_choice,
+                                decline_by_default_at: DateTime.now,
+                                decline_by_default_days: 10,
+                                application_form: build(:application_form, recruitment_cycle_year: 2024))
+
+    described_class.new.change
+
+    application_choice.reload
+    expect(application_choice.decline_by_default_days).to be_nil
+    expect(application_choice.decline_by_default_at).to be_nil
+  end
+
+  it 'updates only 2024 application choices' do
+    application_2024 = create(:application_choice, decline_by_default_at: Time.zone.now,
+                                                   application_form: build(:application_form, recruitment_cycle_year: 2024))
+    application_2023 = create(:application_choice, decline_by_default_at: Time.zone.now,
+                                                   application_form: build(:application_form, recruitment_cycle_year: 2023))
+
+    described_class.new.change
+
+    expect(application_2024.reload.decline_by_default_at).to be_nil
+    expect(application_2023.reload.decline_by_default_at).not_to be_nil
+  end
+end