Generate undergraduate test applications #9876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have on our service postgraduate and undergraduate courses I am generating test application for the teacher degree apprenticeship program
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
tomas-stefano
commented
Sep 26, 2024
| .in_cycle(recruitment_cycle_year) | ||
|
|
||
| if courses.count.zero? | ||
| provider = Provider.all.sample(10).sample || FactoryBot.create(:provider) |
There was a problem hiding this comment.
I don't care what provider is created from those applications and at this point I suspect each developer has your own provider favorite that test locally or QA. Let me know if you have strong opinions about this.
There was a problem hiding this comment.
I tend to use provider code 1TZ becuase they have primary and secondary courses by default. Only saying as you asked.
There was a problem hiding this comment.
@inulty-dfe I pushed one commit using the 1TZ as first try and if there isn't one, they will go to the next or statement and select at random.
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
inulty-dfe
approved these changes
Sep 30, 2024
tomas-stefano
deleted the
2354-tda-setup-the-right-courses-data-for-find-apply
branch
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Now that we have on our service postgraduate and undergraduate courses I am generating test application for the teacher degree apprenticeship program
Guidance to review