-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2315] part 3, Ignore redundant decline_by_default columns #9877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elceebee
force-pushed
the
pr3-2315-remove-default-by-default-at-column
branch
from
September 26, 2024 16:09
2da320c
to
b5c0435
Compare
You have one or more flakey tests on this branch! ❄️ ❄️ ❄️Failed 1 out of 3 times at ./spec/services/support_interface/notes_export_spec.rb:19: |
elceebee
force-pushed
the
pr3-2315-remove-default-by-default-at-column
branch
from
September 27, 2024 15:41
a191b9a
to
2658344
Compare
elceebee
force-pushed
the
pr3-2315-remove-default-by-default-at-column
branch
from
September 27, 2024 16:05
2658344
to
80a2f36
Compare
elceebee
changed the title
Ignore redundant decline_by_default columns
[2315] part 3, Ignore redundant decline_by_default columns
Sep 30, 2024
CatalinVoineag
approved these changes
Sep 30, 2024
dcyoung-dev
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👌
elceebee
had a problem deploying
to
review_aks
September 30, 2024 12:28 — with
GitHub Actions
Failure
elceebee
force-pushed
the
pr3-2315-remove-default-by-default-at-column
branch
from
September 30, 2024 12:33
80a2f36
to
1273ad7
Compare
elceebee
force-pushed
the
pr3-2315-remove-default-by-default-at-column
branch
from
October 1, 2024 16:22
1273ad7
to
0fac725
Compare
elceebee
force-pushed
the
pr3-2315-remove-default-by-default-at-column
branch
from
October 2, 2024 14:04
0fac725
to
6c07c9f
Compare
elceebee
force-pushed
the
pr3-2315-remove-default-by-default-at-column
branch
from
October 3, 2024 08:48
6c07c9f
to
92174ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is the third PR to address a bug where
decline_by_default_at
anddecline_by_default_days
were being set inconsistently. See the first PR here for context and then the second to see what else has been done.Changes proposed in this pull request
We will ignore these to columns and stop syncing them with BigQuery. This approach has been confirmed with the data team.
We are not deleting the columns because the data is still relevant pre-continuous applications when the dates were used and the decline by default job was run every day.
Guidance to review
Things to check