Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2315] part 3, Ignore redundant decline_by_default columns #9877

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

elceebee
Copy link
Contributor

@elceebee elceebee commented Sep 26, 2024

Context

This is the third PR to address a bug where decline_by_default_at and decline_by_default_days were being set inconsistently. See the first PR here for context and then the second to see what else has been done.

Changes proposed in this pull request

  • Some final clean up, removing some uses of these fields
  • ignoring these columns
  • ignoring the columns has some impact on the raw sql we use for sorting, so there are some changes there as well.

We will ignore these to columns and stop syncing them with BigQuery. This approach has been confirmed with the data team.

We are not deleting the columns because the data is still relevant pre-continuous applications when the dates were used and the decline by default job was run every day.

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

@elceebee
Copy link
Contributor Author

@elceebee elceebee force-pushed the pr3-2315-remove-default-by-default-at-column branch from 2da320c to b5c0435 Compare September 26, 2024 16:09
Copy link
Contributor

You have one or more flakey tests on this branch! ❄️ ❄️ ❄️

Failed 1 out of 3 times at ./spec/services/support_interface/notes_export_spec.rb:19: ⚠️ PG::UniqueViolation: ERROR: duplicate key value violates unique constraint "index_providers_on_code" DETAIL: Key (code)=(AB1) already exists.

@elceebee elceebee force-pushed the pr3-2315-remove-default-by-default-at-column branch from a191b9a to 2658344 Compare September 27, 2024 15:41
@elceebee elceebee force-pushed the pr3-2315-remove-default-by-default-at-column branch from 2658344 to 80a2f36 Compare September 27, 2024 16:05
@elceebee elceebee marked this pull request as ready for review September 27, 2024 16:06
@elceebee elceebee changed the title Ignore redundant decline_by_default columns [2315] part 3, Ignore redundant decline_by_default columns Sep 30, 2024
@elceebee elceebee requested a review from a team September 30, 2024 09:51
Copy link
Collaborator

@dcyoung-dev dcyoung-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

config/analytics_blocklist.yml Show resolved Hide resolved
@elceebee elceebee added the deploy_v2 Deploy the review app to AKS label Sep 30, 2024
@elceebee elceebee force-pushed the pr3-2315-remove-default-by-default-at-column branch from 80a2f36 to 1273ad7 Compare September 30, 2024 12:33
@github-actions github-actions bot temporarily deployed to review_aks-9877 September 30, 2024 12:39 Destroyed
@elceebee elceebee force-pushed the pr3-2315-remove-default-by-default-at-column branch from 1273ad7 to 0fac725 Compare October 1, 2024 16:22
@github-actions github-actions bot temporarily deployed to review_aks-9877 October 1, 2024 16:36 Destroyed
@elceebee elceebee force-pushed the pr3-2315-remove-default-by-default-at-column branch from 0fac725 to 6c07c9f Compare October 2, 2024 14:04
@github-actions github-actions bot temporarily deployed to review_aks-9877 October 2, 2024 14:25 Destroyed
@elceebee elceebee force-pushed the pr3-2315-remove-default-by-default-at-column branch from 6c07c9f to 92174ae Compare October 3, 2024 08:48
@github-actions github-actions bot temporarily deployed to review_aks-9877 October 3, 2024 09:17 Destroyed
@elceebee elceebee merged commit 84fbee2 into main Oct 3, 2024
60 checks passed
@elceebee elceebee deleted the pr3-2315-remove-default-by-default-at-column branch October 3, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants