Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1638 - feat(cms): ability to update participating schools #1624

Merged
merged 1 commit into from
Oct 11, 2023
Merged

1638 - feat(cms): ability to update participating schools #1624

merged 1 commit into from
Oct 11, 2023

Conversation

EdwinKruglov
Copy link
Contributor

Changes in this PR

  • allow the user to update the participating schools on a case that as a MAT, trust, or a foundation as its organisation
  • add a confirmation page when changing the organisation on a case that has participating schools

Jira: PWNN-1638

@EdwinKruglov EdwinKruglov self-assigned this Sep 27, 2023
@viezly
Copy link

viezly bot commented Sep 27, 2023 •
edited
Loading

This pull request is split into 6 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • app
  • app/views
  • config
  • db/migrate
  • spec/factories/support
  • spec/features/support

@EdwinKruglov EdwinKruglov force-pushed the pwnn-1638-ability-to-update-school-list-on-cms branch 5 times, most recently from 8dcc6bf to 82697d9 Compare September 29, 2023 14:06
@ryantk ryantk force-pushed the pwnn-1638-ability-to-update-school-list-on-cms branch 2 times, most recently from e919be1 to 80df871 Compare October 11, 2023 08:44
@ryantk ryantk force-pushed the pwnn-1638-ability-to-update-school-list-on-cms branch from 80df871 to f4fcc88 Compare October 11, 2023 08:52
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ryantk ryantk merged commit ad05a84 into main Oct 11, 2023
19 checks passed
@ryantk ryantk deleted the pwnn-1638-ability-to-update-school-list-on-cms branch October 11, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantk ryantk ryantk approved these changes

@serenaabbott11 serenaabbott11 Awaiting requested review from serenaabbott11 serenaabbott11 is a code owner

Assignees

@EdwinKruglov EdwinKruglov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdwinKruglov @ryantk