Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1659 - feat(e&o): add school picker to case creation #1627

Merged
merged 3 commits into from
Oct 27, 2023
Merged

1659 - feat(e&o): add school picker to case creation #1627

merged 3 commits into from
Oct 27, 2023

Conversation

EdwinKruglov
Copy link
Contributor

@EdwinKruglov EdwinKruglov commented Sep 29, 2023 •
edited
Loading

Changes in this PR

  • create case_requests to hold the information of the initial request for a case
  • remove routes and views that create cases directly as this is now done by case_requests
  • add the school picker to the E&O and ProcOps case request creation flows

Jira: PWNN-1659

@EdwinKruglov EdwinKruglov self-assigned this Sep 29, 2023
@viezly
Copy link

viezly bot commented Sep 29, 2023 •
edited
Loading

This pull request is split into 11 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • app
  • app/controllers
  • app/models
  • app/presenters/support
  • app/views
  • config
  • db
  • spec/features
  • spec/forms/support

@EdwinKruglov EdwinKruglov force-pushed the pwnn-1659-e-and-o-multischool-picker branch from b270a1a to 2212e03 Compare September 29, 2023 16:18
@EdwinKruglov EdwinKruglov changed the base branch from pwnn-1638-ability-to-update-school-list-on-cms to main September 29, 2023 16:18
@EdwinKruglov EdwinKruglov force-pushed the pwnn-1659-e-and-o-multischool-picker branch 5 times, most recently from 1dde104 to 24ebeab Compare October 13, 2023 14:07
@EdwinKruglov EdwinKruglov changed the title WIP - 1659 - feat(e&o): add school picker to case creation 1659 - feat(e&o): add school picker to case creation Oct 13, 2023
@EdwinKruglov EdwinKruglov marked this pull request as ready for review October 13, 2023 14:22
@EdwinKruglov EdwinKruglov force-pushed the pwnn-1659-e-and-o-multischool-picker branch 5 times, most recently from e898a26 to 52b4f0d Compare October 19, 2023 15:20
@EdwinKruglov EdwinKruglov force-pushed the pwnn-1659-e-and-o-multischool-picker branch from 52b4f0d to 25e2df4 Compare October 27, 2023 09:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@EdwinKruglov EdwinKruglov merged commit 54a10f3 into main Oct 27, 2023
19 checks passed
@EdwinKruglov EdwinKruglov deleted the pwnn-1659-e-and-o-multischool-picker branch October 27, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantk ryantk ryantk approved these changes

@serenaabbott11 serenaabbott11 Awaiting requested review from serenaabbott11 serenaabbott11 is a code owner

Assignees

@EdwinKruglov EdwinKruglov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdwinKruglov @ryantk