Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cms): school details tab shown in other tabs #1633

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

EdwinKruglov
Copy link
Contributor

Changes in this PR

  • fixes a bug where the content of the School Details tab was being shown in other tabs if the tab is specified in the URL hash

@EdwinKruglov EdwinKruglov added the bug Something isn't working label Oct 11, 2023
@EdwinKruglov EdwinKruglov requested a review from cocoaken October 11, 2023 13:23
@EdwinKruglov EdwinKruglov self-assigned this Oct 11, 2023
@viezly
Copy link

viezly bot commented Oct 11, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ryantk
Copy link
Contributor

ryantk commented Oct 11, 2023

@EdwinKruglov good work, can you deploy it to development and I will check and approve. Thanks

@EdwinKruglov EdwinKruglov merged commit 2dfec7d into main Oct 11, 2023
19 checks passed
@EdwinKruglov EdwinKruglov deleted the fix-school-details-tab branch October 11, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants