Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1574 - feat(rfh): edit confirmation email #1634

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

serenaabbott11
Copy link
Contributor

Changes in this PR

Changes to the email confirmation after submitting a request for help, mainly changing the request message for a summary of information.

Screen-shots or screen-capture of UI changes

@serenaabbott11 serenaabbott11 added the enhancement New feature or request label Oct 11, 2023
@serenaabbott11 serenaabbott11 self-assigned this Oct 11, 2023
@viezly
Copy link

viezly bot commented Oct 11, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@serenaabbott11 serenaabbott11 force-pushed the pwnn-1574-rfh-confirmation-email branch from 79ef5c4 to 3d4ffe7 Compare October 11, 2023 15:45
Copy link
Contributor

@ryantk ryantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor amendment to make

app/presenters/framework_request_presenter.rb Outdated Show resolved Hide resolved
@serenaabbott11 serenaabbott11 force-pushed the pwnn-1574-rfh-confirmation-email branch from 3d4ffe7 to 0bf2229 Compare October 18, 2023 09:08
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@serenaabbott11 serenaabbott11 merged commit d931434 into main Oct 19, 2023
19 checks passed
@serenaabbott11 serenaabbott11 deleted the pwnn-1574-rfh-confirmation-email branch October 19, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants