Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC-82 Upload Documents (evaluation pack) #2013

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

edwin-jebaraj
Copy link
Collaborator

Changes in this PR

  1. app/controllers/support/cases/document_uploads_controller.rb - Added new document upload controller
  2. app/controllers/support/document_downloads_controller.rb - Added new class name in download controller
  3. app/models/support/case.rb - Included uploaded document object
  4. app/models/support/case/document_uploadable.rb - Added new document uploadable model
  5. app/models/support/case/document_uploader.rb - Added new document uploader model
  6. app/models/support/case_upload_document.rb - Added new model
  7. app/views/support/cases/document_uploads/_form.html.erb - Added new view file
  8. app/views/support/cases/document_uploads/_uploaded_documents.html.erb - Added new view file
  9. app/views/support/cases/document_uploads/destroy.html.erb - Added new view file for delete screen
  10. app/views/support/cases/show/_tasklist.html.erb - Updated upload documents link
  11. config/locales/en.yml - Added new language variable
  12. config/locales/validation/support/en.yml - Added new language variable
  13. config/routes.rb - Added new routes for upload document
  14. db/migrate/20241203125734_add_support_case_upload_documents.rb - Added new migration file to upload document data
  15. spec/features/support/agent_can_upload_evaluation_documents_spec.rb - Added new spec testing file

Screen-shots or screen-capture of UI changes

Copy link
Collaborator

@threedaymonk threedaymonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good (just a couple of notes) but when you demonstrated it there were quite a lot of scenarios, like deleting a file that's newly uploaded, deleting a file that exists, resetting the confirmation if all files are deleted. It would be good to capture those in a few more title specs to explain what happens in the edge cases.

app/models/support/case_upload_document.rb Outdated Show resolved Hide resolved
@edwin-jebaraj edwin-jebaraj force-pushed the SC-82-upload-documents branch 2 times, most recently from 1ebfa09 to 0558b06 Compare December 8, 2024 19:53
Copy link

github-actions bot commented Dec 8, 2024

Test coverage

Line: 87.16%
Branch: 77.13%

Copy link

github-actions bot commented Dec 9, 2024

Test coverage

Line: 87.18%
Branch: 77.13%

Copy link
Collaborator

@threedaymonk threedaymonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good except for the name of the field, I think.

@edwin-jebaraj edwin-jebaraj force-pushed the SC-82-upload-documents branch from 0c8df69 to 53865e7 Compare December 9, 2024 12:30
Copy link

github-actions bot commented Dec 9, 2024

Test coverage

Line: 87.04%
Branch: 76.98%

@edwin-jebaraj edwin-jebaraj force-pushed the SC-82-upload-documents branch from 0c5abae to 112a61b Compare December 9, 2024 13:29
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

github-actions bot commented Dec 9, 2024

Test coverage

Line: 87.04%
Branch: 76.98%

Copy link

github-actions bot commented Dec 9, 2024

Test coverage

Line: 87.2%
Branch: 77.09%

@edwin-jebaraj edwin-jebaraj merged commit 3f4e8c1 into main Dec 9, 2024
24 of 25 checks passed
@edwin-jebaraj edwin-jebaraj deleted the SC-82-upload-documents branch December 9, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants