-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SC-82 Upload Documents (evaluation pack) #2013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good (just a couple of notes) but when you demonstrated it there were quite a lot of scenarios, like deleting a file that's newly uploaded, deleting a file that exists, resetting the confirmation if all files are deleted. It would be good to capture those in a few more title specs to explain what happens in the edge cases.
1ebfa09
to
0558b06
Compare
Test coverageLine: 87.16% |
Test coverageLine: 87.18% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good except for the name of the field, I think.
db/migrate/20241203125911_add_is_upload_documents_to_support_cases.rb
Outdated
Show resolved
Hide resolved
0c8df69
to
53865e7
Compare
Test coverageLine: 87.04% |
0c5abae
to
112a61b
Compare
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
Test coverageLine: 87.04% |
Test coverageLine: 87.2% |
Changes in this PR
Screen-shots or screen-capture of UI changes