SC-150 - Refactor email address validation #2028
Open
+49
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test coverageLine: 87.01% |
serenaabbott11
force-pushed
the
sc-150-refactor-email-validation
branch
from
6f44d0d to
66919ae
Compare
|
serenaabbott11
changed the title
serenaabbott11
requested review from
threedaymonk and
edwin-jebaraj
as code owners
threedaymonk
approved these changes
Jan 30, 2025
Comment on lines
+4
to
+5
| validates :email, email_address: { format: true } | ||
| validates :email, email_address: { school_email: true } |
There was a problem hiding this comment.
I think these can be merged into one line:
validates :email, email_address: { format: true, school_email: true }but don't let it get in the way of getting this finished and merged!
There was a problem hiding this comment.
thank you! I tried this and it weirdly didn't work - but it may have been due to the mess of other files i had going on at the time! will try again tomorrow then pass over to QA 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
Screen-shots or screen-capture of UI changes