Refactor to avoid invoking Rake task in specs (which is unreliable in…

… CI)

app/jobs/import_census_job.rb

@@ -1,8 +1,10 @@
+require "analytics_importer"
+
 class ImportCensusJob < FileImporterJob
   import_with SchoolWorkforceCensusDataImporter
   rescue_with -> do
     SchoolWorkforceCensus.delete_all
-    Rake::Task["dfe:analytics:import_entity"].invoke(SchoolWorkforceCensus.table_name) if DfE::Analytics.enabled?
+    AnalyticsImporter.import(SchoolWorkforceCensus)
   end
   notify_with AdminMailer, success: :census_csv_processing_success, failure: :census_csv_processing_error
 end

app/jobs/import_student_loans_data_job.rb

@@ -1,3 +1,5 @@
+require "analytics_importer"
+
 class ImportStudentLoansDataJob < FileImporterJob
   import_with StudentLoansDataImporter do
     Rails.logger.info "SLC data imported; student loan verifiers will re-run where necessary"
@@ -7,6 +9,6 @@ class ImportStudentLoansDataJob < FileImporterJob
   end
   rescue_with -> do
     StudentLoansData.delete_all
-    Rake::Task["dfe:analytics:import_entity"].invoke(StudentLoansData.table_name) if DfE::Analytics.enabled?
+    AnalyticsImporter.import(StudentLoansData)
   end
 end

lib/analytics_importer.rb

@@ -0,0 +1,5 @@
+class AnalyticsImporter
+  def self.import(model)
+    Rake::Task["dfe:analytics:import_entity"].invoke(model.table_name) if DfE::Analytics.enabled?
+  end
+end

lib/csv_importer/base.rb

@@ -1,4 +1,5 @@
 require "csv"
+require "analytics_importer"
 
 module CsvImporter
   class Base
@@ -33,7 +34,7 @@ def run
         target_data_model.insert_all(record_hashes) unless record_hashes.empty?
       end
 
-      Rake::Task["dfe:analytics:import_entity"].invoke(target_data_model.table_name) if DfE::Analytics.enabled?
+      AnalyticsImporter.import(target_data_model)
     end
 
     def rows_with_data_count

spec/jobs/import_census_job_spec.rb

@@ -47,11 +47,9 @@
         expect(FileUpload.find_by_id(file_upload.id)).to be_present
       end
 
-      describe "dfe-analytics syncing", :with_dfe_analytics_enabled do
-        let(:dbl) { double(run: true) }
+      describe "dfe-analytics syncing" do
         it "invokes the relevant import entity job" do
-          expect(DfE::Analytics::LoadEntities).to receive(:new).with(entity_name: SchoolWorkforceCensus.table_name).and_return(dbl)
-          expect(dbl).to receive(:run)
+          expect(AnalyticsImporter).to receive(:import).with(SchoolWorkforceCensus)
           subject.perform(file_upload.id)
         end
       end

spec/jobs/import_student_loans_data_job_spec.rb

@@ -54,11 +54,9 @@
         expect { upload }.not_to have_enqueued_job(StudentLoanPlanCheckJob)
       end
 
-      describe "dfe-analytics syncing", :with_dfe_analytics_enabled do
-        let(:dbl) { double(run: true) }
+      describe "dfe-analytics syncing" do
         it "invokes the relevant import entity job" do
-          expect(DfE::Analytics::LoadEntities).to receive(:new).with(entity_name: StudentLoansData.table_name).and_return(dbl)
-          expect(dbl).to receive(:run)
+          expect(AnalyticsImporter).to receive(:import).with(StudentLoansData)
           upload
         end
       end

spec/lib/csv_importer/base_spec.rb

@@ -79,11 +79,9 @@
     end
   end
 
-  describe "dfe-analytics syncing", :with_dfe_analytics_enabled do
-    let(:dbl) { double(run: true) }
+  describe "dfe-analytics syncing" do
     it "invokes the relevant import entity job" do
-      expect(DfE::Analytics::LoadEntities).to receive(:new).with(entity_name: target_data_model.table_name).and_return(dbl)
-      expect(dbl).to receive(:run)
+      expect(AnalyticsImporter).to receive(:import).with(target_data_model)
       importer.run
     end
   end

spec/rails_helper.rb

@@ -91,5 +91,3 @@
   config.filter_run_excluding js: true unless ENV["RUN_JS_SPECS"] == "true"
   config.filter_run_excluding slow: true unless ENV["RUN_SLOW_SPECS"] == "true"
 end
-
-Rails.application.load_tasks